Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google News #2790

Merged
merged 3 commits into from Jun 16, 2020
Merged

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Mar 16, 2020

Google News

Issue: Closes #2783

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Possible alternative colour: #4285f4 (Google Blue)

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Mar 16, 2020
@ericcornelissen
Copy link
Contributor

I'm seeing some minor difference with the "G" and "lines" besides it as seen below. Not sure how that happened as they seem more different than I would expect from optimizing. Which version of the logo did you source the SVG from? I used "Full-color horizontal lockup – Preferred" for my comparison.

image

@PeterShaggyNoble
Copy link
Member Author

From the differently rounded corners in the lines, it looks like we have indeed used different versions to each other. It's been a while, but I'm pretty sure I based mine on the "One-color horizontal lockup" SVG.

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the differently rounded corners in the lines, it looks like we have indeed used different versions to each other. It's been a while, but I'm pretty sure I based mine on the "One-color horizontal lockup" SVG.

That one looks spot on, and given that it's already monochrome I'm totally fine with using that as a source 👍

@ericcornelissen ericcornelissen merged commit 6873c85 into simple-icons:develop Jun 16, 2020
@ericcornelissen
Copy link
Contributor

Thanks for the work on this one @PeterShaggyNoble 👍

@PeterShaggyNoble PeterShaggyNoble deleted the googlenews branch June 19, 2020 14:30
@github-actions github-actions bot mentioned this pull request Jun 21, 2020
github-actions bot added a commit that referenced this pull request Jun 21, 2020
# New Icons

- Ansys (#3211)
- Google News (#2790)
- Mini (#3210)
- Shikimori (#3179)
- Trove (#3069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google News
2 participants