Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scratch #2872

Merged
merged 3 commits into from Jun 4, 2020
Merged

Add Scratch #2872

merged 3 commits into from Jun 4, 2020

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Mar 30, 2020

Scratch

Issue: Closes #2870

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Colour from website stylesheet. Possible alternatives: #f9a83a or #0fbd8c.

Rejected alternative icons:
Scratch
Scratch
Scratch

Or option 3 with the same treatment as option 1 or 2.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Mar 30, 2020
@locness3
Copy link

locness3 commented Apr 3, 2020

I would go with the scratch-1.

@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label Apr 3, 2020
@ericcornelissen
Copy link
Contributor

Though I like the current version more visually, I do agree that scratch-1 would be better. I would say it is closer to the original version and the website favicon.

@PeterShaggyNoble PeterShaggyNoble removed the in discussion There is an ongoing discussion that should be finished before we can continue label Jun 4, 2020
@PeterShaggyNoble
Copy link
Member Author

OK, PR updated to use that option of the icon.

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @PeterShaggyNoble 👌 With @locness3's blessing on blue for the colour I will be merging this.

@ericcornelissen ericcornelissen merged commit 148a5d1 into simple-icons:develop Jun 4, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the scratch branch June 4, 2020 14:06
ericcornelissen pushed a commit that referenced this pull request Jun 7, 2020
# New Icons

- GeeksforGeeks (#3072)
- Jasmine (#3152)
- KTM (#2997)
- Metro de la Ciudad de México (#3156)
- Metro de Madrid (#3153)
- N26 (#3133)
- Prime Video (#3025)
- Scratch (#2872)
- Shenzhen Metro (#3158)
- Tokyo Metro (#3157)
- TuneIn (#3115)
- VirusTotal (#3182)

# Updated Icons

- Bitwarden (#3150)
- SpaceX (#3159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request : Scratch
3 participants