Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sky #2996

Merged
merged 1 commit into from May 26, 2020
Merged

Add Sky #2996

merged 1 commit into from May 26, 2020

Conversation

PeterShaggyNoble
Copy link
Member

Sky

Issue: Closes #2987

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon from this SVG found in header of source URL. Colour from this page.
Possible alternative name to avoid future clashes: Sky Group

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Apr 28, 2020
runxel
runxel approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! You found a svg! 🥳
PR looks very good :)
I would it add "as is", but you certainly got a point with name clashing. But I'd rather go with Sky TV then? 🤔
On the other hand we could also use "first serve" principle here; and Sky seems like a really big and established brand ;)

@PeterShaggyNoble
Copy link
Member Author

Yep, I'd be OK with just going with Sky, for the reasons you mention. But, if we do decide to go with an alternative, I'd push for the "Sky Group" parent as, these days, they have their fingers in a lot more pies than just TV.

@runxel
Copy link
Member

runxel commented May 26, 2020

Okay, first come, first serve.
Thanks again for the work! 👋

@runxel runxel merged commit 50f1af9 into simple-icons:develop May 26, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the sky branch May 26, 2020 15:19
@github-actions github-actions bot mentioned this pull request May 31, 2020
Merged
ericcornelissen added a commit that referenced this pull request May 31, 2020
@ericcornelissen
Release 8 new icons and 1 updated icon (v2.15.0)
ede54cb 
# New Icons

- Carto (#3103)
- ClickUp (#3128)
- Consul (#3078)
- Razer (#3022)
- Sky (#2996)
- The Conversation (#3065)
- YouTube Music (#3098)
- iHeartRadio (#3106)

# Updated Icons

- Google Scholar (#3093)
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jun 29, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runxel runxel runxel approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sky broadcaster icon
2 participants
@PeterShaggyNoble @runxel