Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add The Conversation #3065

Merged
merged 1 commit into from May 26, 2020
Merged

Conversation

davidjb
Copy link
Contributor

@davidjb davidjb commented May 13, 2020

theconversation

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Color determined from the SVG logo at https://theconversation.com/au/republishing-guidelines. Speech bubble part of the logo was extracted, which is the icon used as the site's Favicon and focal point of other media (such as reports).

The Conversation ranks at 2246 on Alexa (https://www.alexa.com/siteinfo/theconversation.com) -- popular in the research and journalism sectors.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label May 13, 2020
@PeterShaggyNoble
Copy link
Member

Thanks for the contribution, @davidjb 👍

The SVG is coming in at 24.002 wide, which is usually down to the precision used when optimising the path. Could you fix that, please?

Personally, I'm not entirely sold that the orange is the correct choice for the colour. Looking through their website, it seems to be used as an accent colour rather than a primary colour. From their website, I'd expect the primary brand colour to be the grey used in the logo.

@PeterShaggyNoble PeterShaggyNoble added changes requested in discussion There is an ongoing discussion that should be finished before we can continue labels May 13, 2020
@davidjb
Copy link
Contributor Author

davidjb commented May 14, 2020

@PeterShaggyNoble Updated the SVG and made sure the path is exactly 24.000 wide. Is there a command that could be run perhaps as part of the lint process to ensure width/height are okay?

As for the choice of colour, the grey is used a bit and but it doesn't feel like the primary branding colour with the reddish-orange (eg #d8352a) being the eye-catching and prominent colour used in on the site (logo, favicon, active links in navigation, image content, web app icons) and most social media (eg Facebook). That said, the grey turns up as the website footer, bold nav links and on their YouTube as their icon.


Edit: the orange turns up a lot more prominently after some form of update today:

Screen Shot 2020-05-14 at 18 17 09

Featured in the modal, then the CTA at the top, and then another CTA as you scroll and in the right-hand column down the page, as well as the primary colour on paper-style buttons as shown on an article page.


The orange does turn up as a primary colour in their reports' diagrams, maps, headings, signage, shirts, etc (eg the 2017/2018 reports use it particularly heavily):

@ericcornelissen
Copy link
Contributor

Regarding the color, I would agree that a reddish-orange is the brand color. The gray feels more like it is just used to contrast the white background of the website.

The icon looks good now 👍 I'll leave the final decision (given the color) to @PeterShaggyNoble or a third @simple-icons/maintainers.


Is there a command that could be run perhaps as part of the lint process to ensure width/height are okay?

That would be awesome, I'm not aware of any tool that can do that for us out of the box, but it would certainly be useful!

@davidjb
Copy link
Contributor Author

davidjb commented May 26, 2020

That would be awesome, I'm not aware of any tool that can do that for us out of the box, but it would certainly be useful!

@ericcornelissen See what you think of #3107 😀

@PeterShaggyNoble
Copy link
Member

At the time of my initial review, the orange was being used very little on their site but, given how prominent it is now, I'm happy to run with it. Thanks for your work on this one, @davidjb.

@PeterShaggyNoble PeterShaggyNoble merged commit c62d2b3 into simple-icons:develop May 26, 2020
@ericcornelissen ericcornelissen removed the in discussion There is an ongoing discussion that should be finished before we can continue label May 26, 2020
ericcornelissen added a commit that referenced this pull request May 31, 2020
# New Icons

- Carto (#3103)
- ClickUp (#3128)
- Consul (#3078)
- Razer (#3022)
- Sky (#2996)
- The Conversation (#3065)
- YouTube Music (#3098)
- iHeartRadio (#3106)

# Updated Icons

- Google Scholar (#3093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants