Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeeksforGeeks icon (#2779) #3072

Merged
merged 1 commit into from Jun 3, 2020

Conversation

phatbhoy67
Copy link
Contributor

@phatbhoy67 phatbhoy67 commented May 13, 2020

geeksforgeeks (1)

Issue: Closes #2779

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Manual vector based on official favicon available in source of website using "Georgia" font as starting point.

official favicon

Hex value #0F9D58 as suggested by @PeterShaggyNoble in #2779

Build passed

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label May 13, 2020
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @phatbhoy67 👍

As it's a manual recreation, though, we'll need someone else to throw another eye over it first, of course.

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all the choices here. Huge thanks for the manual vectorization of the logo @phatbhoy67 😃

@ericcornelissen ericcornelissen merged commit 5d46b58 into simple-icons:develop Jun 3, 2020
@phatbhoy67 phatbhoy67 deleted the geeks branch June 4, 2020 12:47
ericcornelissen pushed a commit that referenced this pull request Jun 7, 2020
# New Icons

- GeeksforGeeks (#3072)
- Jasmine (#3152)
- KTM (#2997)
- Metro de la Ciudad de México (#3156)
- Metro de Madrid (#3153)
- N26 (#3133)
- Prime Video (#3025)
- Scratch (#2872)
- Shenzhen Metro (#3158)
- Tokyo Metro (#3157)
- TuneIn (#3115)
- VirusTotal (#3182)

# Updated Icons

- Bitwarden (#3150)
- SpaceX (#3159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geeksforgeeks
3 participants