Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Consul #3078

Merged
merged 1 commit into from May 29, 2020
Merged

Add Consul #3078

merged 1 commit into from May 29, 2020

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented May 13, 2020 •
edited

Consul

Issue: #2393

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon based on 6 - Consul\1 - Primary - Horizontal\RGB\AI\Consul_PrimaryLogo_Black_RGB.ai from this zip. Given the issues @foo-dogsquared raised in the first PR, I redrew all the circles, maintaining the dimensions of the originals.

Alexa rank: ~167k

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label May 13, 2020
runxel
runxel reviewed May 22, 2020
View reviewed changes
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First: Thanks for all the work on this one, Peter.
But did you really redraw all circles, because the bigger one in the center still looks a bit malformed (not totally round). 🤔

@runxel runxel added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label May 22, 2020
@PeterShaggyNoble
Copy link
Member Author

Must be a trick of the eye, @runxel; I drew another circle over it to make sure something hadn't gone askew in the optimisation process and it lined up perfectly.

@PeterShaggyNoble PeterShaggyNoble removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label May 26, 2020
@runxel
Copy link
Member

runxel commented May 26, 2020

Oh wait. So I was wrong one time (deleted that comment), but I still need to beg to differ:

c2

@PeterShaggyNoble
Copy link
Member Author

🤔 I can't recreate that in Inkscape, @runxel - drawing a new circle of the same dimensions and positioning it at the same coordinates, I see no difference between the two.

@runxel
Copy link
Member

runxel commented May 26, 2020

Witchcraft.gif
🧙🏻‍♂️
Sooo Illustrator is doing shenanigans with me again. True, I can't reproduce this error in Inkscape as well. Amazingly enough the control point structure changes completely when loaded into Illustrator. Never seen happen anything like this....

@ericcornelissen ericcornelissen merged commit ad5c6cd into simple-icons:develop May 29, 2020
@ericcornelissen
Copy link
Contributor

Went ahead and merged this in as it seemed everything is fine (at least it the SVG looks good at my end) 👍

@PeterShaggyNoble PeterShaggyNoble deleted the consul branch May 29, 2020 15:03
@github-actions github-actions bot mentioned this pull request May 31, 2020
Merged
ericcornelissen added a commit that referenced this pull request May 31, 2020
@ericcornelissen
Release 8 new icons and 1 updated icon (v2.15.0)
ede54cb 
# New Icons

- Carto (#3103)
- ClickUp (#3128)
- Consul (#3078)
- Razer (#3022)
- Sky (#2996)
- The Conversation (#3065)
- YouTube Music (#3098)
- iHeartRadio (#3106)

# Updated Icons

- Google Scholar (#3093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runxel runxel runxel left review comments

@foo-dogsquared foo-dogsquared Awaiting requested review from foo-dogsquared

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterShaggyNoble @runxel @ericcornelissen