Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YouTube Music #3098

Merged
merged 4 commits into from May 24, 2020
Merged

Add YouTube Music #3098

merged 4 commits into from May 24, 2020

Conversation

idac73
Copy link
Contributor

@idac73 idac73 commented May 21, 2020

youtubemusic

Issue: Closes #3090

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Build passed

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label May 21, 2020
@idac73
Copy link
Contributor Author

idac73 commented May 22, 2020

Hi! 👋! I have an iHeartRadio icon ready to go too. I'm too lazy for creating multiple forks, so I'll wait in the queue. :-)

@ericcornelissen
Copy link
Contributor

ericcornelissen commented May 22, 2020

Hi! 👋! I have an iHeartRadio icon ready to go too. I'm too lazy for creating multiple forks, so I'll wait in the queue. :-)

Notice that the commit for iHeartRadio has replaced YouTube Music in this Pull Request. Could you undo that (for example by force pushing 7cb2c9c).

For the future, you don't have to create multiple forks. You simply have to create branches. To get started with that I recommend reading this article. If you want to create a branch now I recommend you first checkout to f2ac002 and then create a branch for iHeartRadio. If you're using a command line you can use the sequence of commands below. If you need any help feel free to ask us here!

git checkout f2ac002a12eb1565f167b54a624910d31031cf0c
git checkout -b original-develop
git checkout -b icon-iheartradio
git commit -m "Add iHeartRadio"
git push origin icon-iheartradio

And to fix this Pull Request you can use

git checkout develop
git checkout -b tmp
git checkout 7cb2c9c815ab40190da49cb4a9f65d4bb3a1f458
git branch -D develop
git checkout -b develop
git push origin develop --force

@ericcornelissen ericcornelissen added the pending Issues that are pending because of e.g. a scheduled brand update label May 22, 2020
This reverts commit e755383.
@idac73
Copy link
Contributor Author

idac73 commented May 22, 2020

🤦‍♂️ - sorry about that. Late night unintentional autopilot commit. I didn't know I could branch for this project as well. Will do and apologies for the inconvenience!

@ericcornelissen ericcornelissen removed the pending Issues that are pending because of e.g. a scheduled brand update label May 23, 2020
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG looks good, could you update the source URL to the one I suggested as it contains more guidelines about the logo

_data/simple-icons.json Outdated Show resolved Hide resolved
Changes accepted :-)

Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
@ericcornelissen ericcornelissen merged commit 7b456f4 into simple-icons:develop May 24, 2020
@ericcornelissen
Copy link
Contributor

Thanks a bunch for the contribution @thrash4life, it's much appreciated 🎉

ericcornelissen added a commit that referenced this pull request May 31, 2020
# New Icons

- Carto (#3103)
- ClickUp (#3128)
- Consul (#3078)
- Razer (#3022)
- Sky (#2996)
- The Conversation (#3065)
- YouTube Music (#3098)
- iHeartRadio (#3106)

# Updated Icons

- Google Scholar (#3093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YoutTube Music
3 participants