Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iHeartRadio #3102

Closed
NovaGL opened this issue May 23, 2020 · 8 comments · Fixed by #3106
Closed

iHeartRadio #3102

NovaGL opened this issue May 23, 2020 · 8 comments · Fixed by #3106
Assignees
@idac73
Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project new icon Issues or pull requests for adding a new icon

Comments

@NovaGL
Copy link
Contributor

NovaGL commented May 23, 2020

Name: iHeart Radio
Website:
Official resources for icon and color: https://brand.iheart.com/

I've already uploaded a SVG without text here which I think is good

iHeartRadio SVG

@NovaGL NovaGL added the new icon Issues or pull requests for adding a new icon label May 23, 2020
@ericcornelissen
Copy link
Contributor

Thanks for the request @NovaGL, incidentally @thrash4life already has an SVG ready for this and will (I think) open a Pull Request for it shortly 🙂

@ericcornelissen ericcornelissen added the good first issue Issues we believe are simple and a good first stab at contributing to the project label May 23, 2020
@NovaGL
Copy link
Contributor Author

NovaGL commented May 24, 2020

Thanks for the update. I have updated my SVG to match the format anyway.

I have made several icons in the correct format, so if you like them all that needs to be done is the json part.

SVG Icons

@ericcornelissen ericcornelissen linked a pull request May 24, 2020 that will close this issue
Add iHeartRadio #3106
Merged
3 tasks
@NovaGL NovaGL closed this as completed May 26, 2020
@idac73 idac73 mentioned this issue May 26, 2020
Merged
3 tasks
@ericcornelissen
Copy link
Contributor

In the event that #3106 does not get merged, I'm going to keep this open for a bit just so we don't forget about it 🙂

@NovaGL
Copy link
Contributor Author

NovaGL commented May 26, 2020

No problem. I thought the reverse haha. Why would it not be merged?

@ericcornelissen
Copy link
Contributor

No problem. I thought the reverse haha. Why would it not be merged?

Well, in this case changes have been requested for the PR. Occasionally the original contributor doesn't follow up and fix the changes in which case we usually close the Pull Request and mark it as abandoned. Then someone else can take a shot at adding the icon.

@idac73

This comment has been minimized.

Sign in to view
@PeterShaggyNoble

This comment has been minimized.

Sign in to view
@idac73

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idac73 idac73

Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add iHeartRadio idac73/simple-icons
4 participants
@idac73 @ericcornelissen @PeterShaggyNoble @NovaGL