Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Carto #3103

Merged
merged 3 commits into from May 27, 2020
Merged

Add Carto #3103

merged 3 commits into from May 27, 2020

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented May 23, 2020

carto

Issue: Closes #3075

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@mondeja mondeja mentioned this pull request May 23, 2020
Closed
3 tasks
@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label May 23, 2020
@mondeja mondeja changed the title Add Carto. Add Carto May 26, 2020
@PeterShaggyNoble
Copy link
Member

Thanks for the contribution, @mondeja.

Your path, however, is coming in at 23.989 wide - could you look into that, please?

@mondeja
Copy link
Member Author

mondeja commented May 26, 2020

I've increased the precission of SVGO optimization, that I think it's was failing.

@PeterShaggyNoble
Copy link
Member

Thanks for the quick update, @mondeja. But I'm seeing some differences between your version (in red below) and the source file I'm using. Which version did you base your icon off, as I may not be comparing like with like?

@mondeja
Copy link
Member Author

mondeja commented May 26, 2020 •
edited

Seems that the file has been updated this morning. I was found that Printed positive version Carto website logo was downloading the negative version, I've reported this error to their developers team and this morning was changed:

May 25, 2020, 12:43:20 PM EDT
Hello Álvaro,
Our team informs us that the error in the main portal of CARTO (the switched logos) is now fixed, please check it out!

So I will update it again.

@mondeja mondeja marked this pull request as draft May 26, 2020 15:27
@PeterShaggyNoble

This comment has been minimized.

Sign in to view
@mondeja mondeja marked this pull request as ready for review May 26, 2020 15:47
PeterShaggyNoble
PeterShaggyNoble approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks spot on to me now, @mondeja - thanks for your work on this one 👍

@PeterShaggyNoble PeterShaggyNoble merged commit fb3c923 into simple-icons:develop May 27, 2020
@mondeja mondeja deleted the carto branch May 27, 2020 21:34
NovaGL added a commit to NovaGL/simple-icons that referenced this pull request May 28, 2020
@NovaGL
Merge pull request #1 from simple-icons/develop
c88deea 
Add Carto (simple-icons#3103)
@github-actions github-actions bot mentioned this pull request May 31, 2020
Merged
ericcornelissen added a commit that referenced this pull request May 31, 2020
@ericcornelissen
Release 8 new icons and 1 updated icon (v2.15.0)
ede54cb 
# New Icons

- Carto (#3103)
- ClickUp (#3128)
- Consul (#3078)
- Razer (#3022)
- Sky (#2996)
- The Conversation (#3065)
- YouTube Music (#3098)
- iHeartRadio (#3106)

# Updated Icons

- Google Scholar (#3093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carto
3 participants
@mondeja @PeterShaggyNoble @ericcornelissen