Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iHeartRadio #3106

Merged
merged 3 commits into from May 28, 2020
Merged

Add iHeartRadio #3106

merged 3 commits into from May 28, 2020

Conversation

idac73
Copy link
Contributor

@idac73 idac73 commented May 24, 2020

iheartradio

Issue: Closes #3102

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@ericcornelissen ericcornelissen linked an issue May 24, 2020 that may be closed by this pull request
@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label May 24, 2020
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @thrash4life 👍

Unfortunately, from their brand guidelines:

DON'T use the Logo Mark itself should never be used without the correct usage of the Logo Type.

So we'll need to use the stacked version with the wordmark included here. I'd also suggest updating the source URL to https://brand.iheart.com/logo

@idac73
Copy link
Contributor Author

idac73 commented May 26, 2020

Crap - I need some help here @ericcornelissen and @PeterShaggyNoble

I can't reduce the SVG down any further.

iheartradio.svg.zip

@idac73

This comment has been minimized.

@NovaGL
Copy link
Contributor

NovaGL commented May 27, 2020

@thrash4life I agree, their branding is inconsistent. I just uploaded the Stitcher logo and and wondering the same thing.

@ericcornelissen
Copy link
Contributor

ericcornelissen commented May 27, 2020

@thrash4life and @NovaGL, it is not uncommon for brands to specify something in their brand guidelines that they don't adhere to themselves, typically in places such as app icons.

From my/our perspective, it is quite reasonable for them to do this (especially in places such as app icons) while requiring that outsiders adhere to the guidelines. This is simply to ensure that you don't use their logo to mean something else.

Therefore, generally speaking, we prefer to follow explicit guidelines and include text if necessary even if app icons (or similar) do not include text.

@ericcornelissen
Copy link
Contributor

I can't reduce the SVG down any further.

Can you elaborate @thrash4life? I did not do a thorough comparison to the original, but this seems to match the source quite well.

@PeterShaggyNoble
Copy link
Member

Other than it being a shade over 24 high, your SVG looks fine to me, too, @thrash4life.

I created the SVG from an EPS rather than from the AI, so now there's a single path (no clip path) which also permitted the SI Preview Generator to render as expected.
@idac73

This comment has been minimized.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @thrash4life

However, your path is coming in at 23.179 high, rather than 24. You should also be able to drop the precision a good bit on it when optimising it (although I haven't checked myself yet).

@PeterShaggyNoble
Copy link
Member

Looks perfect to me know - thanks for your efforts on this one, @thrash4life 👍

@PeterShaggyNoble PeterShaggyNoble merged commit bd8b46c into simple-icons:develop May 28, 2020
@idac73
Copy link
Contributor Author

idac73 commented May 28, 2020

Looks perfect to me know - thanks for your efforts on this one, @thrash4life 👍

It was fun and I was happy to contribute again. Thanks for the encouragement and support @PeterShaggyNoble and @ericcornelissen

@PeterShaggyNoble
Copy link
Member

Looking forward to your future contributions 🙂

ericcornelissen added a commit that referenced this pull request May 31, 2020
# New Icons

- Carto (#3103)
- ClickUp (#3128)
- Consul (#3078)
- Razer (#3022)
- Sky (#2996)
- The Conversation (#3065)
- YouTube Music (#3098)
- iHeartRadio (#3106)

# Updated Icons

- Google Scholar (#3093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iHeartRadio
4 participants