Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tunein #3115

Merged
merged 7 commits into from Jun 4, 2020
Merged

Add Tunein #3115

merged 7 commits into from Jun 4, 2020

Conversation

NovaGL
Copy link
Contributor

@NovaGL NovaGL commented May 27, 2020

simpleicons

Issue: Closes #2974

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Manually changed logo from wide version.

Hex values can be found using this website or the media kit PDF mentioned
TuneIn Press

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label May 27, 2020
@PeterShaggyNoble
Copy link
Member

Thanks for the PR, @NovaGL 👍 Note that you've mixed up your Tumblr & TuneIn source URLs in the JSON 😉 I'd also suggest updating the source URL to https://cms.tunein.com/press/ - should their icon ever be updated, that's going to be the best starting point for future contributors.

For those with the eye for comparing raster with vector, there's a PNG version of this logo at https://cdn-web.tunein.com/assets/img/default-item-v2.png

As a matter of personal preference and without any guidance to say otherwise, I'd have gone with the darker blue but I can see why you went with the lighter.

@NovaGL
Copy link
Contributor Author

NovaGL commented May 27, 2020

Thanks @PeterShaggyNoble. I've updated the source.

The color along all of there press sites is the lighter one, although the background is the darker one.
Let me know if other changes are required.

@PeterShaggyNoble
Copy link
Member

I took the liberty of fixing the issue that was causing the build to fail for you - there was some trailing whitespace after the source URL.

Given that they don't state a preference, I'm happy to go with either colour, the darker one is just my own preference.

I'll leave the review of the SVG to those that are better than I at comparing raster to vector.

@NovaGL
Copy link
Contributor Author

NovaGL commented May 30, 2020

Thanks Peter, I updated the size of the image as I think it was 23 wide instead of 24.

@PeterShaggyNoble
Copy link
Member

That's still coming in a bit under 24 wide, @NovaGL, at 23.925.

@NovaGL
Copy link
Contributor Author

NovaGL commented Jun 2, 2020

Intresting. How do I make sure it's correct as Illustrator likes to play games.

@PeterShaggyNoble
Copy link
Member

Most software will allow you to manually enter the dimensions somewhere, @NovaGL, with an option to constrain the proportions relative to each other so you only need change one dimension. I'm not familiar with Illustrator but in Inkscape, for example, it looks like this.

@NovaGL
Copy link
Contributor Author

NovaGL commented Jun 3, 2020

Alright, I redid it in Inkscape no matter how many times I did it in Illustrator it was never 24 width. I used a different method to resize to 24 this time as it was loosing some quality and edges were looking weird. It still uses SVGO as the last step.

Hopefully this is good now.

Remove blank line
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual vectorization looks good to me, nice job 👍

Also, the SVG width is now good (at least according to #3107) and as I'm okay with both this and the darker blue I will be merging this as is 🙂

@ericcornelissen ericcornelissen merged commit 416def1 into simple-icons:develop Jun 4, 2020
ericcornelissen pushed a commit that referenced this pull request Jun 7, 2020
# New Icons

- GeeksforGeeks (#3072)
- Jasmine (#3152)
- KTM (#2997)
- Metro de la Ciudad de México (#3156)
- Metro de Madrid (#3153)
- N26 (#3133)
- Prime Video (#3025)
- Scratch (#2872)
- Shenzhen Metro (#3158)
- Tokyo Metro (#3157)
- TuneIn (#3115)
- VirusTotal (#3182)

# Updated Icons

- Bitwarden (#3150)
- SpaceX (#3159)
@NovaGL NovaGL mentioned this pull request Dec 2, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TuneIn
3 participants