Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickup icon #3128

Merged
merged 4 commits into from May 29, 2020
Merged

Clickup icon #3128

merged 4 commits into from May 29, 2020

Conversation

dstrants
Copy link
Contributor

@dstrants dstrants commented May 28, 2020

ClickUp

Issue: Closes #3127

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Adds the ClickUp logo

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label May 28, 2020
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @dstrants - everything looks spot on to me, nicely done 👍

However, for some reason, the PR says you made changes to the existing icons/razer.svg file but, unless I'm going blind, I can't actually see any difference in the markup! Could you roll back the commit that made that change before we merge this in, please?

@dstrants
Copy link
Contributor Author

Yeah, I noticed that also, but I can't figure out what is causing this weird issue. In fact, as soon as I clone either the main repo or my fork, icons/razer.svg gets registered in unstaged changes without even opening the project in the code editor. I tried to ignore changes but it seems to keep coming back again and again. I'll have a second look though. Any ideas are more than welcome 😃

@PeterShaggyNoble
Copy link
Member

Curious 🤔 Are you branching from master or develop?

@dstrants
Copy link
Contributor Author

dstrants commented May 28, 2020

It defaults to develop so I branched from there? Could that be the issue?

@PeterShaggyNoble
Copy link
Member

No, that's correct. I'm at a loss here, too 🤷‍♂️ Any of the other @simple-icons/maintainers have an idea as to what the problem might be?

@dstrants
Copy link
Contributor Author

It seems that the issue is related with LF and CRLF as described here.
I tried to git stash, git reset --hard, git checkout. Git acts as expected but then it keeps the file in the unstaged changes.

I even tried the configuration that is suggested in SO but still no luck.

@ericcornelissen
Copy link
Contributor

Definitely looks like a LF/CRLF issue, I'm actually experiencing the same at my end (on Ubuntu). But, curiously, when I commit a fix for it on develop at my end it still tells me there is a difference between this branch and develop...

Trying to investigate what's going on here and how best to solve it.

@ericcornelissen ericcornelissen merged commit a2bd18b into simple-icons:develop May 29, 2020
@ericcornelissen
Copy link
Contributor

Thanks for adding the Clickup icon @dstrants, your contribution is much appreciated 🎉

@dstrants
Copy link
Contributor Author

My pleasure @ericcornelissen! Thank you and @PeterShaggyNoble for the support on the issue with razer.svg 😃

ericcornelissen added a commit that referenced this pull request May 31, 2020
# New Icons

- Carto (#3103)
- ClickUp (#3128)
- Consul (#3078)
- Razer (#3022)
- Sky (#2996)
- The Conversation (#3065)
- YouTube Music (#3098)
- iHeartRadio (#3106)

# Updated Icons

- Google Scholar (#3093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClickUp Icon
3 participants