Add Metro de Madrid #3153
Merged
Add Metro de Madrid #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterShaggyNoble
requested changes
Jun 2, 2020
There was a problem hiding this comment.
Nice work, @mondeja - SVG looks perfect to me and I agree with the use of colour which is heavily used on their website.
The only change I'd suggest is in the naming; we recently add Métro de Paris under the original, French name and, where it makes sense, I think that's something we should continue to do for all languages using the Latin alphabet so could you update the name of this to "Metro de Madrid", please?
|
@PeterShaggyNoble It's done. |
|
Thanks, @mondeja. Just need to capitalise "Madrid" in the JSON and change the |
|
Thanks for your work on this one, @mondeja 👍 |
ericcornelissen
pushed a commit
that referenced
this pull request
Jun 7, 2020
# New Icons - GeeksforGeeks (#3072) - Jasmine (#3152) - KTM (#2997) - Metro de la Ciudad de México (#3156) - Metro de Madrid (#3153) - N26 (#3133) - Prime Video (#3025) - Scratch (#2872) - Shenzhen Metro (#3158) - Tokyo Metro (#3157) - TuneIn (#3115) - VirusTotal (#3182) # Updated Icons - Bitwarden (#3150) - SpaceX (#3159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2822
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description