Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metro de la Ciudad de México #3156

Merged
merged 4 commits into from Jun 4, 2020
Merged

Add Metro de la Ciudad de México #3156

merged 4 commits into from Jun 4, 2020

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Jun 2, 2020

metrodeciudaddemexico

Issue: #2822

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jun 2, 2020
@ghost ghost mentioned this pull request Jun 2, 2020
17 tasks
@PeterShaggyNoble
Copy link
Member

Hmm ... the Lance Wyman design, would appear to be an officially commissioned one and the SVG of the other one is an original work based on a JPG, which could account for the fact that the 2 versions don't line up. So, despite the fact that they don't use it on their website (that I can see, at least), I'm OK with the source you've chosen.

Your SVG looks spot on when compared to the source and, of the two colours, the one you've chosen is closest to what they use on their site but the shade they use, as seen on this page is actually #f77e1c so I think that's what we should go with.

Other than that, you're just missing the "la" from the name - Metro de la Ciudad de México

@PeterShaggyNoble
Copy link
Member

Thanks for your work on this one, @mondeja 👍

@PeterShaggyNoble PeterShaggyNoble merged commit 89c101b into simple-icons:develop Jun 4, 2020
@mondeja mondeja changed the title Add Metro de Ciudad de México Add Metro de la Ciudad de México Jun 4, 2020
@mondeja mondeja deleted the metro-ciudad-mexico branch June 4, 2020 12:03
ericcornelissen pushed a commit that referenced this pull request Jun 7, 2020
# New Icons

- GeeksforGeeks (#3072)
- Jasmine (#3152)
- KTM (#2997)
- Metro de la Ciudad de México (#3156)
- Metro de Madrid (#3153)
- N26 (#3133)
- Prime Video (#3025)
- Scratch (#2872)
- Shenzhen Metro (#3158)
- Tokyo Metro (#3157)
- TuneIn (#3115)
- VirusTotal (#3182)

# Updated Icons

- Bitwarden (#3150)
- SpaceX (#3159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants