Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shenzhen Metro #3158

Merged
merged 2 commits into from Jun 4, 2020
Merged

Add Shenzhen Metro #3158

merged 2 commits into from Jun 4, 2020

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Jun 2, 2020

shenzhenmetro

Issue: #2822

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Logo from Wikipedia English page.
  • Hex value from logo file.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jun 2, 2020
@PeterShaggyNoble
Copy link
Member

Nice work, @mondeja 👍 The SVG looks good to me. However, I wonder if we shouldn't fix the issue of the two outermost "feet" not touching the bottom of the canvas in order to match the "arms"?

I think we should use #009943 for the colour, as that's what they use on their website.

Other than that, can you update the source URL to https://en.wikipedia.org/wiki/File:Shenzhen_Metro_Corporation_logo_full.svg?

@PeterShaggyNoble PeterShaggyNoble added changes requested in discussion There is an ongoing discussion that should be finished before we can continue labels Jun 3, 2020
@ericcornelissen
Copy link
Contributor

I wonder if we shouldn't fix the issue of the two outermost "feet" not touching the bottom of the canvas in order to match the "arms"?

From the logo on the homepage I would say yes 🤔

I think we should use #9943 for the colour, as that's what they use on their website.

Without proper guidelines, I think either the current and the suggested value would work as a color for this brand. I would personally lean to the slightly lighter #13A034 that is currently in the metadata.

@PeterShaggyNoble

This comment has been minimized.

@ericcornelissen

This comment has been minimized.

…color and update source for Shenzhen Metro icon.
@PeterShaggyNoble
Copy link
Member

Ah, sorry, thought you meant their site's metadata! 🤦‍♂️

@mondeja
Copy link
Member Author

mondeja commented Jun 4, 2020

I've opted for #009943 in the new commit and updated the preview. Let me know if you prefer #13a034.

@ericcornelissen ericcornelissen removed changes requested in discussion There is an ongoing discussion that should be finished before we can continue labels Jun 4, 2020
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVG looks spot on, nice work @mondeja 🎊 #009943 also works for me so I will be merging this as is 😃

@ericcornelissen ericcornelissen merged commit 4af3a7b into simple-icons:develop Jun 4, 2020
@mondeja mondeja deleted the shenzhen-metro branch June 4, 2020 13:43
ericcornelissen pushed a commit that referenced this pull request Jun 7, 2020
# New Icons

- GeeksforGeeks (#3072)
- Jasmine (#3152)
- KTM (#2997)
- Metro de la Ciudad de México (#3156)
- Metro de Madrid (#3153)
- N26 (#3133)
- Prime Video (#3025)
- Scratch (#2872)
- Shenzhen Metro (#3158)
- Tokyo Metro (#3157)
- TuneIn (#3115)
- VirusTotal (#3182)

# Updated Icons

- Bitwarden (#3150)
- SpaceX (#3159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants