Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SpaceX #3159

Merged
merged 1 commit into from Jun 5, 2020
Merged

Update SpaceX #3159

merged 1 commit into from Jun 5, 2020

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Jun 3, 2020 •
edited by ericcornelissen

SpaceX

Issue: rel: #1314, #3141

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon from SVG embedded in website header, colour from stylehseet.

Comparison

With our current version in red.

@PeterShaggyNoble PeterShaggyNoble added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jun 3, 2020
phatbhoy67
phatbhoy67 approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@phatbhoy67 phatbhoy67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this icon @PeterShaggyNoble much appreciated 👍

@phatbhoy67 phatbhoy67 merged commit 0a301e1 into simple-icons:develop Jun 5, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the update/spacex branch June 5, 2020 11:22
@github-actions github-actions bot mentioned this pull request Jun 7, 2020
Merged
ericcornelissen pushed a commit that referenced this pull request Jun 7, 2020
@github-actions
Release 12 new icons and 2 updated icons (v2.16.0)
227318a 
# New Icons

- GeeksforGeeks (#3072)
- Jasmine (#3152)
- KTM (#2997)
- Metro de la Ciudad de México (#3156)
- Metro de Madrid (#3153)
- N26 (#3133)
- Prime Video (#3025)
- Scratch (#2872)
- Shenzhen Metro (#3158)
- Tokyo Metro (#3157)
- TuneIn (#3115)
- VirusTotal (#3182)

# Updated Icons

- Bitwarden (#3150)
- SpaceX (#3159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phatbhoy67 phatbhoy67 phatbhoy67 approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeterShaggyNoble @phatbhoy67