Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apache ECharts #3166

Merged

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Jun 4, 2020

Apache ECharts

Issue: #2887 (ref: #2444)

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Getting the ball rolling on #2877.

I tweaked a few things here:

  1. Removed the minor imperfection on the bottom of the whale(?),
  2. Assumed the circle is meant to be perfect, and,
  3. Redrew the circle to correct a minor issue with the top right arc.

Comparison

With our current version in red.

Apache ECharts

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jun 4, 2020
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jun 4, 2020
17 tasks
@PeterShaggyNoble PeterShaggyNoble added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both and removed new icon Issues or pull requests for adding a new icon labels Jun 4, 2020
@ericcornelissen ericcornelissen merged commit bbf35c8 into simple-icons:develop Jun 11, 2020
@ericcornelissen
Copy link
Contributor

Thanks for updating this 👍

@PeterShaggyNoble PeterShaggyNoble deleted the update/apacheecharts branch June 12, 2020 09:42
ericcornelissen added a commit that referenced this pull request Jun 14, 2020
# New Icons

- Canonical (#3184)
- Der Spiegel (#3168)
- DHL (#3048)
- Land Rover (#3195)
- Openlayers (#3165)
- Prime (#3010)
- Quasar (#3144)

# Updated Icons

- Apache ECharts (#3166)
- Apache Pulsar (#3181)
- Fur Affinity (#2979)
- Jupyter (#3170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants