Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Der Spiegel #3168

Merged
merged 2 commits into from Jun 11, 2020
Merged

Add Der Spiegel #3168

merged 2 commits into from Jun 11, 2020

Conversation

PeterShaggyNoble
Copy link
Member

Der Spiegel

Issue: Closes #3051

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG and colour from website header. I wonder would we get away with just using the "S", as they do in their favicon and preloaders? 馃

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jun 4, 2020
runxel
runxel approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work, Peter! 馃憤
Looks fine to me, and I would advise against just the "S".
I don't think it works very well, even though I understand it might be compelling to use this compact format.

@runxel runxel merged commit 9788036 into simple-icons:develop Jun 11, 2020
@PeterShaggyNoble
Copy link
Member Author

I would advise against just the "S".
I don't think it works very well, even though I understand it might be compelling to use this compact format.

I don't think I've ever seen it used anywhere outside their website, and there their branding is already well established.

@PeterShaggyNoble PeterShaggyNoble deleted the derspiegel branch June 12, 2020 09:57
@github-actions github-actions bot mentioned this pull request Jun 14, 2020
Merged
ericcornelissen added a commit that referenced this pull request Jun 14, 2020
@ericcornelissen
Release 7 new icons and 4 updated icons
833241e 
# New Icons

- Canonical (#3184)
- Der Spiegel (#3168)
- DHL (#3048)
- Land Rover (#3195)
- Openlayers (#3165)
- Prime (#3010)
- Quasar (#3144)

# Updated Icons

- Apache ECharts (#3166)
- Apache Pulsar (#3181)
- Fur Affinity (#2979)
- Jupyter (#3170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runxel runxel runxel approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPIEGEL logo request
2 participants
@PeterShaggyNoble @runxel