Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jupyter icon #3170

Merged
merged 2 commits into from Jun 11, 2020
Merged

Update Jupyter icon #3170

merged 2 commits into from Jun 11, 2020

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Jun 4, 2020 •
edited

Jupyter

Issue: #3120 (ref: #1085)

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Kicking off the #3120 review. Icon based on this version

Comparison

With our current version in red.

Jupyter

Build passed

@PeterShaggyNoble PeterShaggyNoble added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jun 4, 2020
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jun 4, 2020
Closed
38 tasks
ericcornelissen
ericcornelissen approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version of the SVG looks spot on (this time I'm 100% 🙃) Thanks for the update @PeterShaggyNoble 🙂

@ericcornelissen ericcornelissen merged commit 1b78c89 into simple-icons:develop Jun 11, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the update/jupyter branch June 12, 2020 09:41
@github-actions github-actions bot mentioned this pull request Jun 14, 2020
Merged
ericcornelissen added a commit that referenced this pull request Jun 14, 2020
@ericcornelissen
Release 7 new icons and 4 updated icons
833241e 
# New Icons

- Canonical (#3184)
- Der Spiegel (#3168)
- DHL (#3048)
- Land Rover (#3195)
- Openlayers (#3165)
- Prime (#3010)
- Quasar (#3144)

# Updated Icons

- Apache ECharts (#3166)
- Apache Pulsar (#3181)
- Fur Affinity (#2979)
- Jupyter (#3170)
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jul 10, 2020
Closed
@mondeja mondeja mentioned this pull request Nov 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeterShaggyNoble @ericcornelissen