New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Apache Pulsar #3181
Update Apache Pulsar #3181
Conversation
Thanks, @mondeja. Am I missing something, though, or is the source URL the only thing that's been changed here. Not the I'm averse to doing this for all Apache brands that don't have their own design guidelines, I also don't think it's strictly necessary if there's no update needed to the SVG. Although, if we are going to update the source URLs for those icons that don't need to be updated and don't have their own guidelines, I'd rather we do them all in a single PR. Any thoughts from the other @simple-icons/maintainers? |
Seems that the path has, at least, one minor change: note the |
That seems correct, but it doesn't seem like a notable difference 🤔 Though I'm not against updating it, I'm also not sure if it's really necessary.
I agree with both of these points. |
And that's why I shouldn't try to "eyeball" the differences between two paths! 😆 It looks like the difference between the 2 is simply one of rounding during the optimisation process as, looking at the path data for the SVG I used vs. the one you used, there are only a very few minor differences with a couple of absolute commands being replaced by relative commands:
So I'd agree with Eric that, while not strictly necessary, updating does no harm and, at the very least, updates to the more correct source URL so I'm going to merge it in. Going forward, though, we should focus initially on those icons where there is a significant visual difference. |
Issue: #2887
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Path extracted from this file.