New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cypress #3228
Add Cypress #3228
Conversation
The Alexa rank of cypress.io is ~36k and with that suitable for inclusion. As you're part of the team at cypress.io I'm willing to merge this in as is. However, based on this SVG linked by @erianvc it seems that the optimization has had some negative impacts on the icon as seen below. Could this be correct, or are you certain the version you added is 100% correct? Relatedly, from the same SVG, it appears that instead of outlining the outer stroke of the circle, the SVG you added simply assumes the circle itself as the totality of the logo. Now again, as you're part of the cypress.io team I'm fine with merging this as is, I'm just checking if this is intended. |
@ericcornelissen After reviewing, I updated the hex to better match our brand guidelines. The slight difference in the optimized logo and the circle being the totality of the logo have been reviewed and are ok to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update and the clarification, @pstakoun 👍 As you are a representative of the brand and you've run this through an internal review, I'm happy to merge this in as-is.
Issue: Closes #3234
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
I'm on the growth engineering team at Cypress. The logo was retrieved from internal marketing assets as used on the website: https://cypress.io.