Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cypress #3228

Merged
merged 2 commits into from Jun 22, 2020
Merged

Add Cypress #3228

merged 2 commits into from Jun 22, 2020

Conversation

pstakoun
Copy link
Contributor

@pstakoun pstakoun commented Jun 16, 2020

cypress

Issue: Closes #3234

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I'm on the growth engineering team at Cypress. The logo was retrieved from internal marketing assets as used on the website: https://cypress.io.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jun 19, 2020
@ericcornelissen ericcornelissen mentioned this pull request Jun 20, 2020
@ericcornelissen
Copy link
Contributor

The Alexa rank of cypress.io is ~36k and with that suitable for inclusion.


As you're part of the team at cypress.io I'm willing to merge this in as is. However, based on this SVG linked by @erianvc it seems that the optimization has had some negative impacts on the icon as seen below.

Could this be correct, or are you certain the version you added is 100% correct?

image

Relatedly, from the same SVG, it appears that instead of outlining the outer stroke of the circle, the SVG you added simply assumes the circle itself as the totality of the logo. Now again, as you're part of the cypress.io team I'm fine with merging this as is, I'm just checking if this is intended.

image

@ericcornelissen ericcornelissen added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jun 21, 2020
@pstakoun
Copy link
Contributor Author

@ericcornelissen After reviewing, I updated the hex to better match our brand guidelines. The slight difference in the optimized logo and the circle being the totality of the logo have been reviewed and are ok to merge.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and the clarification, @pstakoun 👍 As you are a representative of the brand and you've run this through an internal review, I'm happy to merge this in as-is.

@PeterShaggyNoble PeterShaggyNoble merged commit b447c72 into simple-icons:develop Jun 22, 2020
github-actions bot added a commit that referenced this pull request Jun 28, 2020
# New Icons

- Cypress (#3228)
- NestJS (#3113)
- Qt (#3162)
- Sennheiser (#3045)

# Updated Icons

- BMC Software (#3239)
- Intercom (#3227)
ericcornelissen pushed a commit that referenced this pull request Jun 28, 2020
- Cypress (#3228)
- NestJS (#3113)
- Qt (#3162)
- Sennheiser (#3045)

- BMC Software (#3239)
- Intercom (#3227)
@PeterShaggyNoble PeterShaggyNoble removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress icon
3 participants