Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Groovy #3596

Closed
runxel opened this issue Sep 25, 2020 · 2 comments · Fixed by #4120
Closed

Rename Groovy #3596

runxel opened this issue Sep 25, 2020 · 2 comments · Fixed by #4120
Assignees
@ericcornelissen
Labels
breaking change Issues or pull requests that include a breaking change and scheduled for the next major release update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Milestone
v4.0.0

Comments

@runxel
Copy link
Member

runxel commented Sep 25, 2020

The Groovy icon should be renamed to Apache Groovy.

Originally posted by @creepertron95 in #2887 (comment)
@runxel runxel added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Sep 25, 2020
@runxel runxel added this to the v4.0.0 milestone Sep 25, 2020
@runxel runxel added the breaking change Issues or pull requests that include a breaking change and scheduled for the next major release label Sep 26, 2020
@TomerPacific
Copy link

@runxel , I'd like to help with this issue. Apart from making the necessary changes in the simple-icons.json file and icon itself, is there anything else required?

@runxel
Copy link
Member Author

runxel commented Sep 30, 2020 •
edited

Hi @TomerPacific! Thank you so much for offering help! 💯
However I don't think this particular issue needs your attention. We usually batch-rename all necessary items for a new major version since this makes it easier to keep track of them.
But there are a lot of issues and requests waiting to be done! We always enjoy seeing non-maintainers sending in PRs with new icons! 🤗
Looking forward to your contributions

@ericcornelissen ericcornelissen self-assigned this Nov 23, 2020
@ericcornelissen ericcornelissen mentioned this issue Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericcornelissen ericcornelissen

Labels
breaking change Issues or pull requests that include a breaking change and scheduled for the next major release update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Rename Adobe Lightroom CC and Groovy
3 participants
@runxel @ericcornelissen @TomerPacific