Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axios #3821

Closed
vishalicious213 opened this issue Nov 7, 2020 · 10 comments · Fixed by #5991
Closed

axios #3821

vishalicious213 opened this issue Nov 7, 2020 · 10 comments · Fixed by #5991
Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project new icon Issues or pull requests for adding a new icon

Comments

@vishalicious213
Copy link

This is a request for an icon for the axios library for JavaScript.
This one: https://www.npmjs.com/package/axios

Name:
Website:
Alexa rank:

Official resources for icon and color:

@vishalicious213 vishalicious213 added the new icon Issues or pull requests for adding a new icon label Nov 7, 2020
@service-paradis
Copy link
Member

There is no official logo yet for Axios. They discuss about it here.

@vishalicious213
Copy link
Author

Thanks. I didn't remember that. I actually used that site (and the first proposed image) on my portfolio, for axios, early this year. Hopefully something will get decided. I liked some of the rocket designs in that thread.

@mondeja
Copy link
Member

mondeja commented Nov 15, 2020

Please, reopen this the moment they have a logo officialized.

@mondeja mondeja closed this as completed Nov 15, 2020
@service-paradis
Copy link
Member

Reopening since they close the logo request issue:
axios/axios#2130 (comment)

@PeterShaggyNoble
Copy link
Member

@vishalicious213, would you like to have a read through our contributing guidelines and take this one on yourself?

@PeterShaggyNoble PeterShaggyNoble added the good first issue Issues we believe are simple and a good first stab at contributing to the project label Apr 21, 2021
@vishalicious213
Copy link
Author

Thanks for the offer - and sure, I'd love to give it a go!

@PeterShaggyNoble
Copy link
Member

Are you still planning to take this one on, @vishalicious213?

@vishalicious213
Copy link
Author

vishalicious213 commented May 13, 2021 via email

@vishalicious213
Copy link
Author

I worked on the SVG using Inkscape to make it monochromatic, scaled and centered. I then modified the file to include role, viewbox and title information. SVGO removed this information during minification , but I added it back in. I also removed width, height and fill information.

I'll download the repo and add JSON data. I think the data should look like this:

{
"title": "axios",
"hex": "5a29e4",
"source": "https://axios-http.com/assets/logo.svg"
}

I hope I'm doing this right! Thanks for the opportunity and let me know if there's something I need to correct or include.

@PeterShaggyNoble
Copy link
Member

That all sounds and looks good to me, @vishalicious213, if you'd like to proceed with your PR.

3 quick points on the JSON entry, though:

  1. "axios" should have a capital "A",
  2. The hex should be uppercase, and,
  3. You can just use the homepage for the source.

@SimonGolms SimonGolms mentioned this issue Jun 18, 2021
3 tasks
@service-paradis service-paradis linked a pull request Jun 18, 2021 that will close this issue
3 tasks
@t-miller t-miller mentioned this issue Jun 28, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants