Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V2EX icon #5839

Merged
merged 7 commits into from Sep 2, 2022
Merged

Add V2EX icon #5839

merged 7 commits into from Sep 2, 2022

Conversation

Mayandev
Copy link
Contributor

@Mayandev Mayandev commented Jun 3, 2021

CleanShot 2022-09-02 at 23 29 22@2x

Issue: closes #5836
Alexa rank: 2,948
Similarweb rank: 8,669

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Difference preview

CleanShot 2022-09-02 at 23 32 31@2x

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jun 3, 2021
@Mayandev Mayandev changed the title feat: add v2ex Add v2ex icon Jun 3, 2021
@adamrusted adamrusted linked an issue Jun 5, 2021 that may be closed by this pull request
@PeterShaggyNoble
Copy link
Member

Welcome to Simple Icons, @Mayandev, and thanks for the contribution 🙂

Can I ask which file you based your icon off? As the only place I see that icon in use is in their favicon, which wouldn't normally be enough to justify us using it, and there is no vector version available that I can see.

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jun 18, 2021
@Mayandev
Copy link
Contributor Author

Welcome to Simple Icons, @Mayandev, and thanks for the contribution 🙂

Can I ask which file you based your icon off? As the only place I see that icon in use is in their favicon, which wouldn't normally be enough to justify us using it, and there is no vector version available that I can see.

I'm sorry for the late reply, I didn't find the icon source either, this is my own design based on favoricon

@Mayandev
Copy link
Contributor Author

Mayandev commented Apr 11, 2022

Welcome to Simple Icons, @Mayandev, and thanks for the contribution 🙂

Can I ask which file you based your icon off? As the only place I see that icon in use is in their favicon, which wouldn't normally be enough to justify us using it, and there is no vector version available that I can see.

Update,the icon url is: https://www.v2ex.com/static/icon-192.png

favicon

@LitoMore
Copy link
Member

LitoMore commented Sep 2, 2022

@livid Do you have the vector version of your V2EX logo?

If not, I can help to recreate one.

@livid
Copy link

livid commented Sep 2, 2022

@livid Do you have the vector version of your V2EX logo?

If not, I can help to recreate one.

Wow, this is an awesome project! Thanks a lot!

Our current favicon is a modernized redesign by @RayPS based on this 16x16 pixelated legacy version created a decade ago:

https://web.archive.org/web/20060627065058/http://v2ex.com/favicon.ico

https://web.archive.org/web/20101106120836/http://www.v2ex.com/favicon.ico

Feel free to create a vector version; with your permission, we can use it as the official one.

@LitoMore
Copy link
Member

LitoMore commented Sep 2, 2022

@livid Here is my recreated one:

Preview

CleanShot 2022-09-02 at 22 35 10@2x

Source file

You could download the v2ex.sketch file from here: https://www.sketch.com/s/acc31350-dc9f-4a71-bec2-c5914debc514 (based on @RayPS provided one in #5839 (comment))

Or just send the file in SVG format to you via email.

Feel free to use it.

icons/v2ex.svg Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
@LitoMore LitoMore removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Sep 2, 2022
@LitoMore LitoMore changed the title Add v2ex icon Add V2EX icon Sep 2, 2022
@RayPS
Copy link

RayPS commented Sep 2, 2022

@livid Do you have the vector version of your V2EX logo?
If not, I can help to recreate one.

Wow, this is an awesome project! Thanks a lot!

Our current favicon is a modernized redesign by @RayPS based on this 16x16 pixelated legacy version created a decade ago:

https://web.archive.org/web/20060627065058/http://v2ex.com/favicon.ico

https://web.archive.org/web/20101106120836/http://www.v2ex.com/favicon.ico

Feel free to create a vector version; with your permission, we can use it as the official one.

Here's the vector version of the favicon that I created for Livid.

<?xml version="1.0" encoding="UTF-8"?>
<svg width="72px" height="60px" viewBox="0 0 72 60" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
    <g id="Page-1" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
        <path d="M2,0 L43.1881209,0 C44.2949437,-3.9307556e-16 45.3522917,0.458613096 46.1086039,1.26672743 L70.4419372,27.2667274 C71.8812932,28.8046694 71.8812932,31.1953306 70.4419372,32.7332726 L46.1086039,58.7332726 C45.3522917,59.5413869 44.2949437,60 43.1881209,60 L2,60 C0.8954305,60 -8.67738547e-17,59.1045695 0,58 L0,37.5 L0,37.5 L39.3076923,37.5 L46.0895778,30.7065016 C46.479296,30.3161162 46.479296,29.6838838 46.0895778,29.2934984 L39.3076923,22.5 L39.3076923,22.5 L0,22.5 L0,2 C-3.57315355e-16,0.8954305 0.8954305,-1.91384796e-17 2,0 Z" fill="#FFFFFF"></path>
    </g>
</svg>

@LitoMore
Copy link
Member

LitoMore commented Sep 2, 2022

@RayPS Thanks! Will use your one instead.

I've updated my sketch file with your one.

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/v2ex.svg Outdated Show resolved Hide resolved
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LitoMore LitoMore merged commit bc63916 into simple-icons:develop Sep 2, 2022
@github-actions github-actions bot mentioned this pull request Sep 4, 2022
mondeja added a commit that referenced this pull request Sep 4, 2022
# New Icons

- Bun (#7731)
- NextBillion.ai (#7734)
- OpenProject (#7741)
- QMK (#7725)
- V2EX (#5839)
- Wasmer (#7646)
- Windows 11 (#7707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: v2ex Icon
5 participants