Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Axios icon #5991

Merged
merged 15 commits into from Aug 21, 2022
Merged

Add Axios icon #5991

merged 15 commits into from Aug 21, 2022

Conversation

SimonGolms
Copy link
Contributor

axios (1)

Issue: #3821
Alexa rank: 315,678 https://www.alexa.com/siteinfo/axios-http.com
Github stars: 85.2k https://github.com/axios/axios

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • I used Sketch to extracted the arrows from this raw svg file, as this logo is also used as favicon and GitHub profiles.
  • I picked the color #5A29E4 directly from the mentioned file.
  • I used SVGOMG with precision of 3 for further optimization

Sorry for maybe taking over the issue ticket.... I am just checking the tech stack of some of my projects and adding missing logos to be able to use them later in the shields.io badges 馃檭

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jun 18, 2021
@service-paradis service-paradis linked an issue Jun 18, 2021 that may be closed by this pull request
axios #3821
Closed
@PeterShaggyNoble PeterShaggyNoble changed the title feat: add axios icon Add Axios icon Jun 24, 2021
@PeterShaggyNoble
Copy link
Member

Thanks for taking this one on, @SimonGolms 馃憤馃徎

Would you mind having another look at it though, as I am seeing some differences throughout - such as this one in the top left - between the PR version (in red) and the source?

@SimonGolms
Copy link
Contributor Author

axios

You maintainers are just really great at quality control! I picked a precision of 5 on SVGOMG now, which should fix the deviation.

@SimonGolms
Copy link
Contributor Author

@PeterShaggyNoble would be nice if this PR gets the 'hacktoberfest-accepted' label 馃槑

@sachinraja
Copy link
Contributor

sachinraja commented Oct 12, 2021 •
edited

I am not seeing that difference with the newer version, so I will approve this but wait a few days before merging to see if @PeterShaggyNoble can review it.

@service-paradis service-paradis mentioned this pull request Nov 1, 2021
Closed
@service-paradis service-paradis mentioned this pull request Jun 28, 2022
Closed
3 tasks
@dirien
Copy link
Member

dirien commented Aug 12, 2022

@sachinrajam, how should we proceed with this PR?

@sachinraja
Copy link
Contributor

We can merge it @dirien

@dirien
Copy link
Member

dirien commented Aug 16, 2022

Hi @SimonGolms, we just need to get the Lint issue sorted! Then we are ready to merge! 馃槃

@SimonGolms
Copy link
Contributor Author

Thanks for pinging! The linter should be happy now 馃槉

@sachinraja sachinraja merged commit 3573f25 into simple-icons:develop Aug 21, 2022
@SimonGolms SimonGolms deleted the feature/add-axios-icon branch August 21, 2022 19:43
@github-actions github-actions bot mentioned this pull request Aug 28, 2022
Merged
mondeja added a commit that referenced this pull request Aug 28, 2022
@mondeja
Release 7 new icons (v7.9.0)
6cdb8ae 
# New Icons

- .ENV (#7702)
- Axios (#5991)
- Ducati (#7678)
- HarmonyOS (#7682)
- Legacy Games (#7704)
- TableCheck (#7696)
- Wacom (#7680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinraja sachinraja sachinraja approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

axios
5 participants
@SimonGolms @PeterShaggyNoble @sachinraja @dirien @service-paradis