Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taco Bell icon #6945

Merged
merged 5 commits into from Aug 13, 2022
Merged

Taco Bell icon #6945

merged 5 commits into from Aug 13, 2022

Conversation

adsingh14
Copy link
Contributor

Issue: #6944
Alexa rank: 19,384

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

tacobell

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 3, 2021
@service-paradis service-paradis linked an issue Dec 3, 2021 that may be closed by this pull request
Request: Taco Bell #6944
Closed
dirien
dirien requested changes Dec 22, 2021
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adsingh14,

thanks for the contrib. There is some slight difference. Maybe worth to up the precission?

image

dirien
dirien reviewed Dec 23, 2021
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still see some differences:

image

would ask a another maintainers opinion

@LitoMore
Copy link
Member

I guess the different is from the source file. The source file have a white background but not fit.

@dirien Have you removed the background and re-centered the source image?

image

@adsingh14 adsingh14 requested a review from dirien January 2, 2022 06:37
dirien
dirien reviewed Jan 2, 2022
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @LitoMore,

I am using the one from the homepage of tacobell. Its already in black and whithout padding.

image

Still see a remarkable difference in the curve.

@adsingh14

This comment was marked as resolved.

Sign in to view
@dirien
Copy link
Member

dirien commented Aug 12, 2022

Hi @adsingh14,

can you post the svg u used as file in this PR?

@dirien dirien added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 12, 2022
@adsingh14

This comment was marked as resolved.

Sign in to view
@dirien
Copy link
Member

dirien commented Aug 13, 2022

So @adsingh14, it's the logo from wikipedia?

When I look on the homepage, I see also two logos there.

@adsingh14

This comment was marked as resolved.

Sign in to view
dirien
dirien approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adsingh14,

sorry for the back and forth but now its a perfect fit!

image

@dirien dirien merged commit 6bab635 into simple-icons:develop Aug 13, 2022
@github-actions github-actions bot removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 13, 2022
@adsingh14 adsingh14 deleted the tacobell branch August 13, 2022 16:49
@github-actions github-actions bot mentioned this pull request Aug 14, 2022
Merged
mondeja added a commit that referenced this pull request Aug 15, 2022
@mondeja
Release 10 new icons and 1 updated icon (v7.7.0)
babef7c 
# New Icons

- avajs (#7630)
- Bookalope (#7645)
- BookMyShow (#6003)
- F5 (#6100)
- Keystone (#6080)
- LITIENGINE (#7041)
- MonoGames (#7608)
- Revolt.chat (#7395)
- Taco Bell (#6945)
- Traefik Proxy (#7600)

# Updated Icons

- AdonisJS (#7611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirien dirien dirien approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Taco Bell
3 participants
@adsingh14 @LitoMore @dirien