Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Neutralinojs icon #7319

Merged
merged 4 commits into from Sep 13, 2022
Merged

Add Neutralinojs icon #7319

merged 4 commits into from Sep 13, 2022

Conversation

elliotwutingfeng
Copy link
Contributor

@elliotwutingfeng elliotwutingfeng commented Apr 13, 2022 •
edited

image

Issue: closes #3336

GitHub stars: 6k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Neutralinojs is a lightweight and portable desktop application development framework.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Apr 13, 2022
@elliotwutingfeng elliotwutingfeng mentioned this pull request Apr 13, 2022
Closed
dirien
dirien requested changes Sep 12, 2022
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @elliotwutingfeng,

thanks for you contribution. I can see some differences:

image

@dirien
Copy link
Member

dirien commented Sep 12, 2022 •
edited

Hi @elliotwutingfeng,

i still cans see some differences. Strange. 😞

@elliotwutingfeng
Copy link
Contributor Author

elliotwutingfeng commented Sep 12, 2022 •
edited

The original icon is not touching the edges of the viewbox. In inkscape, after ungrouping, the original icon was encapsulated by a blank selection area. I removed that portion, and used Path->Union on the remaining portions to get the icon to touch at least 2 edges of the viewbox.

Scale the icon to fit the viewbox, while preserving the icon's original proportions. This means the icon should be touching at least two sides of the viewbox.

@dirien
Copy link
Member

dirien commented Sep 13, 2022

Hi, @elliotwutingfeng,

sorry forgot about that. But still there is a difference:

image

I removed the first child path from the group of the original svg. Maybe up the precision?

@LitoMore LitoMore changed the title add neutralinojs icon Add Neutralinojs icon Sep 13, 2022
@LitoMore
Copy link
Member

CleanShot 2022-09-13 at 20 40 59@2x

@elliotwutingfeng It's a perfect fit.

@dirien You need to convert all borders to outlines before you resize it.

@dirien dirien merged commit b4c360a into simple-icons:develop Sep 13, 2022
@elliotwutingfeng elliotwutingfeng deleted the neutralinojs branch September 13, 2022 13:34
@github-actions github-actions bot mentioned this pull request Sep 18, 2022
Merged
mondeja added a commit that referenced this pull request Sep 18, 2022
@mondeja
Release 11 new icons and 7 updated icons (v7.12.0)
50eb494 
# New Icons

- Agora (#7765)
- Algorand (#7772)
- Apple News (#7769)
- Commodore (#7773)
- Dataverse (#7782)
- Google Home (#7771)
- Neutralinojs (#7319)
- Power Fx (#7788)
- Power Pages (#7783)
- Semantic Scholar (#7767)
- Sessionize (#7789)

# Updated Icons

- Andela (#7790)
- Dynamics 365 (#7778)
- Neo4j (#7791)
- Power Apps (#7781)
- Power Automate (#7785)
- Power BI (#7784)
- Power Virtual Agents (#7786)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirien dirien Awaiting requested review from dirien

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Neutralinojs
3 participants
@elliotwutingfeng @dirien @LitoMore