Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rubocop icon #7380

Merged
merged 8 commits into from May 8, 2022
Merged

Add Rubocop icon #7380

merged 8 commits into from May 8, 2022

Conversation

zrfisaac
Copy link
Contributor

@zrfisaac zrfisaac commented May 5, 2022

rubocop

Issue: #7368

Similarweb rank: 1,379,435

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

RuboCop is a Ruby code style checker (linter) and formatter based on the community-driven Ruby Style Guide.
RuboCop is extremely flexible and most aspects of its behavior can be tweaked via various configuration options. In practice RuboCop supports pretty much every (reasonably popular) coding style that you can think of.
Apart from reporting problems in your code, RuboCop can also automatically fix some of the problems for you.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label May 5, 2022
@zrfisaac zrfisaac mentioned this pull request May 5, 2022
@pboling
Copy link

pboling commented May 5, 2022

CC @bbatsov the final SVG logo!

_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
icons/rubocop.svg Outdated Show resolved Hide resolved
zrfisaac and others added 3 commits May 7, 2022 18:56
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
@zrfisaac
Copy link
Contributor Author

zrfisaac commented May 7, 2022

Thanks for the help @sisp I didn't notice this, next time I will be more careful.

Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! 🎉 Thanks for making the requested changes, @zrfisaac.

This PR can be merged IMO.

/cc @sachinraja

@sachinraja sachinraja merged commit a2b7b2a into simple-icons:develop May 8, 2022
@sachinraja sachinraja linked an issue May 9, 2022 that may be closed by this pull request
mondeja added a commit that referenced this pull request May 16, 2022
# New Icons

- EnterpriseDB (#7379)
- GTK (#7340)
- mdBook (#7289)
- RuboCop (#7380)
- Steam Deck (#7411)

# Updated Icons

- Ubuntu (#7407)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Rubocop
4 participants