New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add revolt.chat #7395
Add revolt.chat #7395
Conversation
Looks like I need to fix the size and centering, but I'm not sure how, so if you have some steps, lmk. |
Guess I got this stuff to be right now... |
…le-icons into feature/add-revolt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Andre601,
thanks for the contribution but the provided link is not a valid SVG anymore.
https://github.com/revoltchat/revite/blob/master/public/assets_default/badges/revolt_r.svg
In what way? Clicking it brings me to the SVG itself, so it seems to be fine? |
Talking with the devs, it seems like they made the svgs empty... So, remove the source? Otherwise Idk what else I could point as the source here, unless a specific commit URL is acceptable. |
Received a new source URL that can be used and seems to be valid: https://app.revolt.chat/assets/badges/revolt_r.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly can't.... I do not have the experience with SVG to achieve this changes here, so if you (or someone else experienced) could try doing this, I would really appreciate it. And it's weird that it is different as I literally used that exact SVG and tried my best to resize it to the 24x24 viewbox in the end (As you may have guessed from all the commits and failed runs). One thing I am curious now and want to take the opportunity to ask: Would a small difference like this be acceptable, if the owner(s) gave their permission/agreement for it? |
This should hopefully fix the wrong dimensions... If not, then please give me the steps to make it work as I tried the following within Inkscape using the official SVG from https://app.revolt.chat/assets/badges/revolt_r.svg:
Afterwards I did all the SVGOMG shenanigans. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: closes #7314
Similarweb rank: #344,582 (8th of may, 2022)
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
SVG icon of Revolt.chat, an open-source Text and VOIP site.
The SVG is based off a version someone else was providing through a (now discontinued) instance of Simple icons.
Note that this is my first time working with SVG stuff, so please don't hesitate if I messed something up or forgot to improve something.