Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revolt.chat #7395

Merged
merged 15 commits into from Aug 13, 2022
Merged

Add revolt.chat #7395

merged 15 commits into from Aug 13, 2022

Conversation

Andre601
Copy link
Contributor

@Andre601 Andre601 commented May 8, 2022

revoltdotchat

Issue: closes #7314

Similarweb rank: #344,582 (8th of may, 2022)

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG icon of Revolt.chat, an open-source Text and VOIP site.
The SVG is based off a version someone else was providing through a (now discontinued) instance of Simple icons.

Note that this is my first time working with SVG stuff, so please don't hesitate if I messed something up or forgot to improve something.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label May 8, 2022
@Andre601
Copy link
Contributor Author

Andre601 commented May 8, 2022

Looks like I need to fix the size and centering, but I'm not sure how, so if you have some steps, lmk.

@Andre601
Copy link
Contributor Author

Guess I got this stuff to be right now...

Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Andre601,

thanks for the contribution but the provided link is not a valid SVG anymore.

https://github.com/revoltchat/revite/blob/master/public/assets_default/badges/revolt_r.svg

@dirien dirien added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 12, 2022
@Andre601
Copy link
Contributor Author

Andre601 commented Aug 12, 2022

Hi @Andre601,

thanks for the contribution but the provided link is not a valid SVG anymore.

https://github.com/revoltchat/revite/blob/master/public/assets_default/badges/revolt_r.svg

In what way? Clicking it brings me to the SVG itself, so it seems to be fine?
I'm no expert, but from what I can tell is the SVG simply white?

@Andre601
Copy link
Contributor Author

Talking with the devs, it seems like they made the svgs empty...

So, remove the source? Otherwise Idk what else I could point as the source here, unless a specific commit URL is acceptable.

@Andre601
Copy link
Contributor Author

Received a new source URL that can be used and seems to be valid: https://app.revolt.chat/assets/badges/revolt_r.svg

@Andre601 Andre601 requested a review from dirien August 12, 2022 16:45
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I sees some differences. Could you rework the icon in the PR with the new logo?

image

@Andre601
Copy link
Contributor Author

Hi,

I sees some differences. Could you rework the icon in the PR with the new logo?

image

I honestly can't.... I do not have the experience with SVG to achieve this changes here, so if you (or someone else experienced) could try doing this, I would really appreciate it.

And it's weird that it is different as I literally used that exact SVG and tried my best to resize it to the 24x24 viewbox in the end (As you may have guessed from all the commits and failed runs).

One thing I am curious now and want to take the opportunity to ask: Would a small difference like this be acceptable, if the owner(s) gave their permission/agreement for it?

@Andre601
Copy link
Contributor Author

Andre601 commented Aug 12, 2022

This should hopefully fix the wrong dimensions... If not, then please give me the steps to make it work as I tried the following within Inkscape using the official SVG from https://app.revolt.chat/assets/badges/revolt_r.svg:

  • Selected all paths using Edit -> Select all in all layers
  • Opened Object -> Transform
  • Set height to 24.000 pixels while preserving scale proportions
  • Set canvas size to 24x24 pixels
  • Aligned SVG vertically and horizontally in the center.

Afterwards I did all the SVGOMG shenanigans.

Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect fit!

image

@dirien dirien merged commit 17f06cc into simple-icons:develop Aug 13, 2022
@github-actions github-actions bot removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 13, 2022
@Andre601 Andre601 deleted the feature/add-revolt branch August 13, 2022 10:29
mondeja added a commit that referenced this pull request Aug 15, 2022
# New Icons

- avajs (#7630)
- Bookalope (#7645)
- BookMyShow (#6003)
- F5 (#6100)
- Keystone (#6080)
- LITIENGINE (#7041)
- MonoGames (#7608)
- Revolt.chat (#7395)
- Taco Bell (#6945)
- Traefik Proxy (#7600)

# Updated Icons

- AdonisJS (#7611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Revolt
2 participants