Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bookalope icon #7645

Merged
merged 1 commit into from Aug 13, 2022
Merged

Add Bookalope icon #7645

merged 1 commit into from Aug 13, 2022

Conversation

jenstroeger
Copy link
Contributor

Bookalope is a SaaS platform for AI-assisted manuscript analysis, accessible ebook conversion, and more.

bookalope

Issue: closes #7644

Similarweb rank: n/a and https://github.com/bookalope/

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Color and logo have been in use since around 2016 when the project started.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 3, 2022
dirien
dirien requested changes Aug 12, 2022
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jenstroeger,

Thanks for your contribution. Could you check the errors in the lint run please?

Best start is to check the contribution guidlines.

https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md

@dirien dirien added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested labels Aug 12, 2022
@jenstroeger jenstroeger force-pushed the bookalope-icon branch 4 times, most recently from a7da009 to 3f14c24 Compare August 12, 2022 21:41
@jenstroeger
Copy link
Contributor Author

@dirien thank you for the poke. I tried to fix the problems but I’m unable to interpret the “Test package” failures. Also, after following the CONTRIBUTION guidelines lint still fails and I’m not sure how to address these two failures.

I’d be grateful for suggestions!

dirien
dirien requested changes Aug 13, 2022
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the LF/CR? And center the icon please (in inkscape I use
image
)

Last thing, remove the slug field from the simple-icons.json

_data/simple-icons.json Outdated Show resolved Hide resolved
@dirien dirien removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Aug 13, 2022
@jenstroeger jenstroeger force-pushed the bookalope-icon branch 2 times, most recently from fce1b99 to a24f2c4 Compare August 13, 2022 14:05
@jenstroeger
Copy link
Contributor Author

Can you check the LF/CR?

It wasn’t that, but hexdump -C bookalope.svg showed a trailing LF—removed.

And center the icon please (in inkscape I use image )

Done.

Last thing, remove the slug field from the simple-icons.json

Done.

dirien
dirien approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect fit!

image

@dirien dirien merged commit 0e53f39 into simple-icons:develop Aug 13, 2022
@jenstroeger
Copy link
Contributor Author

@dirien oh great, thank you for merging! I look forward to the next release then 🤓

@github-actions github-actions bot mentioned this pull request Aug 14, 2022
Merged
mondeja added a commit that referenced this pull request Aug 15, 2022
@mondeja
Release 10 new icons and 1 updated icon (v7.7.0)
babef7c 
# New Icons

- avajs (#7630)
- Bookalope (#7645)
- BookMyShow (#6003)
- F5 (#6100)
- Keystone (#6080)
- LITIENGINE (#7041)
- MonoGames (#7608)
- Revolt.chat (#7395)
- Taco Bell (#6945)
- Traefik Proxy (#7600)

# Updated Icons

- AdonisJS (#7611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirien dirien dirien approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Bookalope icon
2 participants
@jenstroeger @dirien