Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wasmer icon #7646

Merged
merged 5 commits into from Aug 31, 2022
Merged

Add Wasmer icon #7646

merged 5 commits into from Aug 31, 2022

Conversation

syrusakbary
Copy link
Contributor

@syrusakbary syrusakbary commented Aug 3, 2022 •
edited

image

Issue: closes #7643

Similarweb rank: 291,242 (https://www.similarweb.com/website/wasmer.io)
Github Stars: 12,700 (https://github.com/wasmerio/wasmer/)

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Why did you pick the hex value? Is the brand color
  • Did you manually vectorize the logo? No

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 3, 2022
sisp
sisp suggested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @syrusakbary! 🙏

The icon is perfectly identical with the source SVG image (almost identical data path even). 👍

I have only a few minor requests.

_data/simple-icons.json Outdated
"title": "wasmer",
"hex": "4946DD",
"source": "https://github.com/wasmerio/wasmer.io/blob/0d425f5b4ace56496e75278e304f54492c46adde/public/images/icon.svg",
"guidelines": "https://wasmer.io/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the logo guidelines on this website. Unless I've overlooked it somewhere, please delete this field.

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/wasmer.svg Outdated Show resolved Hide resolved
syrusakbary
syrusakbary commented Aug 16, 2022
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
@syrusakbary @sisp
Apply suggestions from code review in Wasmer icon
d634a22 
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
@syrusakbary
Copy link
Contributor Author

I just fixed the suggestions @sisp . Thanks for reviewing and looking forward to having the PR merged!

@sisp
Copy link
Contributor

sisp commented Aug 17, 2022

@syrusakbary The tests are failing beause of the trailing comma after the source URL. When you remove it, they should pass.

@sisp
Copy link
Contributor

sisp commented Aug 31, 2022

/ping @syrusakbary 😉

@syrusakbary
Copy link
Contributor Author

@Sisip Thanks for following up :)
It should be fixed now!

sisp
sisp approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! 🎉

Thanks again for your contribution, @syrusakbary! 🙏

@sisp sisp merged commit 33d3f10 into simple-icons:develop Aug 31, 2022
@github-actions github-actions bot mentioned this pull request Sep 4, 2022
Merged
mondeja added a commit that referenced this pull request Sep 4, 2022
@mondeja
Release 7 new icons (v7.10.0)
bf2e821 
# New Icons

- Bun (#7731)
- NextBillion.ai (#7734)
- OpenProject (#7741)
- QMK (#7725)
- V2EX (#5839)
- Wasmer (#7646)
- Windows 11 (#7707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisp sisp sisp approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Wasmer Icon
2 participants
@syrusakbary @sisp