New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mastodon colors #7663
Update Mastodon colors #7663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing this! I updated the icon (from this source https://github.com/mastodon/mastodon/blob/main/app/javascript/images/logo-symbol-icon.svg) and amended it to my previous commit to keep things clean, but GitHub doesn't seem to like amended commits after there are "Changes requested". Hope this works anyway. If not, let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the updated icon!
When I compare your updated icon against the GitHub source you mentioned, it looks good:
Just for future reference, it seems the icons used on the website, the blog, etc. are not identical. For instance, there are differences when I compare your updated icon against the icon in the blog hero component (above "Official Mastodon Blog")
and also when I compare it against the icon in the footer of the website:
According to the Git history of the icon you referenced, the branding update was applied to this icon, so I think we should consider it to be the most recent source. But then we should also update the source
field to the GitHub URL (using a permalink - see the source guidelines and my suggested change).
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! 🎉
Issue: closes #7662
Similarweb rank:
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
(unchanged)Description
This PR updates the color hex value of the Mastodon icon according to their branding update announcement: https://blog.joinmastodon.org/2022/06/mastodon-branding-updates/