Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mastodon colors #7663

Merged
merged 3 commits into from Aug 15, 2022
Merged

Update Mastodon colors #7663

merged 3 commits into from Aug 15, 2022

Conversation

merlinscholz
Copy link
Contributor

Issue: closes #7662

Similarweb rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG (unchanged)
  • The SVG viewbox is 0 0 24 24 (unchanged)

Description

This PR updates the color hex value of the Mastodon icon according to their branding update announcement: https://blog.joinmastodon.org/2022/06/mastodon-branding-updates/

Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @ruhrscholz, and for keeping this icon up-to-date! 🙏

As you mentioned in the issue, "the main icon stays mostly the same", so I compared the new one with the one in Simple Icons, and there is quite some difference:

Could you update the icon as well?

@merlinscholz
Copy link
Contributor Author

Thanks for reviewing this! I updated the icon (from this source https://github.com/mastodon/mastodon/blob/main/app/javascript/images/logo-symbol-icon.svg) and amended it to my previous commit to keep things clean, but GitHub doesn't seem to like amended commits after there are "Changes requested". Hope this works anyway. If not, let me know!

@merlinscholz merlinscholz requested a review from sisp August 11, 2022 16:30
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the updated icon!

When I compare your updated icon against the GitHub source you mentioned, it looks good:

Just for future reference, it seems the icons used on the website, the blog, etc. are not identical. For instance, there are differences when I compare your updated icon against the icon in the blog hero component (above "Official Mastodon Blog")

and also when I compare it against the icon in the footer of the website:

According to the Git history of the icon you referenced, the branding update was applied to this icon, so I think we should consider it to be the most recent source. But then we should also update the source field to the GitHub URL (using a permalink - see the source guidelines and my suggested change).

_data/simple-icons.json Outdated Show resolved Hide resolved
@sisp sisp added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Aug 12, 2022
merlinscholz and others added 2 commits August 15, 2022 11:04
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! 🎉

@sisp sisp merged commit 03e3b98 into simple-icons:develop Aug 15, 2022
mondeja added a commit that referenced this pull request Aug 21, 2022
# New Icons

- D (#7285)

# Updated Icons

- Mastodon (#7663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mastodon Color Update
2 participants