Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cairo Graphics icon #7668

Merged
merged 12 commits into from Sep 29, 2022
Merged

Conversation

s-kond
Copy link
Contributor

@s-kond s-kond commented Aug 12, 2022

cairographics

To create the svg-icon, I used inkscape and a svg-file from the github-repository that was linked in the issue:
https://github.com/freedesktop/cairo/blob/44f808fce9f437e14f2b0ef4e1583def8ab578ae/doc/tutorial/slides/cairo-title.svg

There were two primary colors:
- the blue background ("#162284")
- and the yellow/orange scarabaeus ("#f39914")

I picked the yellow/orange "#f39914", because the blue color is just used for the background - but I wasn't sure about that.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 12, 2022
@dirien
Copy link
Member

dirien commented Aug 12, 2022

Hi @s-kond,

thanks for the contribution! Could you check the lint error so I can review your PR? Thanks.

@s-kond
Copy link
Contributor Author

s-kond commented Aug 12, 2022

Hi @dirien,
I checked the lint error and it shows me this:

Data file is formatted incorrectly:
   {
       "icons": [
@@ 12469 more lines
       ]
   }
+
ERROR: "our-lint" exited with 1.

So there should be a formatting error, but I don't know what's wrong or how I can solve this... Can you help me?

@s-kond s-kond changed the title Added Cairo Graphics icon in /icons and _data/simple-icons.json Add Cairo Graphics icon Aug 12, 2022
@s-kond s-kond mentioned this pull request Aug 12, 2022
@dirien
Copy link
Member

dirien commented Aug 12, 2022

Maybe and Windows / Linux CR/LF issue?

_data/simple-icons.json Outdated Show resolved Hide resolved
@mondeja mondeja linked an issue Aug 13, 2022 that may be closed by this pull request
@s-kond
Copy link
Contributor Author

s-kond commented Aug 13, 2022

Simply adding a new line at the end solved the problem, thx!
But it seems I have to change some more things - I'm working on that

Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @s-kond,

I see some little differences

image

Maybe try up the precision to 5?

@s-kond s-kond requested review from mondeja and dirien August 15, 2022 09:31
@mondeja mondeja removed their request for review August 30, 2022 10:48
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @s-kond,

Thanks for your contribution to simple-icons!

I think it's a very close fit!

@dirien dirien merged commit f2564f3 into simple-icons:develop Sep 29, 2022
@mondeja mondeja self-requested a review September 29, 2022 20:46
@mondeja mondeja removed their request for review September 29, 2022 20:46
mondeja added a commit that referenced this pull request Oct 2, 2022
# New Icons

- Cairo Graphics (#7668)
- Greenhouse (#7882)
- Honey (#7893)
- Prevention (#7890)
- SurrealDB (#7856)

# Updated Icons

- .ENV (#7873)
- Ardour (#7873)
- Arduino (#7873)
- Awesome Lists (#7873)
- awesomeWM (#7873)
- CNCF (#7873)
- CodeSandbox (#7878)
- D-EDGE (#7873)
- D-Wave Systems (#7873)
- Dart (#7873)
- Darty (#7873)
- DocuSign (#7873)
- Dogecoin (#7873)
- Electron Fiddle (#7873)
- electron-builder (#7873)
- Elixir (#7873)
- Ello (#7873)
- Gutenberg (#7873)
- Habr (#7873)
- Jamstack (#7873)
- Jasmine (#7873)
- Kubernetes (#7873)
- Kubuntu (#7873)
- Magisk (#7873)
- Mail.Ru (#7873)
- Neutralinojs (#7873)
- New Balance (#7873)
- NixOS (#7873)
- Node-RED (#7873)
- Nunjucks (#7873)
- Nutanix (#7873)
- Open Containers Initiative (#7873)
- Open Source Initiative (#7873)
- Openverse (#7873)
- OSMC (#7873)
- osu! (#7873)
- Packagist (#7873)
- Palantir (#7873)
- Palo Alto Software (#7873)
- QMK (#7873)
- Qt (#7873)
- Redux (#7873)
- Redux-Saga (#7873)
- Resurrection Remix OS (#7873)
- RetroArch (#7873)
- Ruby Sinatra (#7873)
- RubyGems (#7873)
- Sensu (#7873)
- Sentry (#7873)
- Sequelize (#7873)
- Server Fault (#7873)
- Spinnaker (#7873)
- Spinrilla (#7873)
- uBlock Origin (#7873)
- Ubuntu (#7873)
- wasmCloud (#7873)
- Xamarin (#7873)
- XAML (#7873)
- XO (#7873)
- XRP (#7873)
- ZeroMQ (#7873)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cairo Graphics
3 participants