Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TableCheck logo #7696

Merged
merged 10 commits into from Aug 25, 2022
Merged

feat: add TableCheck logo #7696

merged 10 commits into from Aug 25, 2022

Conversation

DragonStuff
Copy link
Contributor

@DragonStuff DragonStuff commented Aug 24, 2022 •
edited

image

Issue: closes #7695

Similarweb rank: 16,183: https://www.similarweb.com/website/tablecheck.com/#overview

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 24, 2022
@DragonStuff DragonStuff changed the title feat: add tablecheck logo feat: add TableCheck logo Aug 24, 2022
@DragonStuff DragonStuff marked this pull request as draft August 24, 2022 05:17
@yusancky
Copy link
Contributor

yusancky commented Aug 24, 2022 •
edited

@DragonStuff I can help you deal with the problem tomorrow if you need. I met it with #7682 , too.

@DragonStuff
Copy link
Contributor Author

@yusancky Please provide any advice you may have! It's definitely appreciated.

@yusancky
Copy link
Contributor

I solved some of the questions. 💡
But it was still worked badly. 😒
It was because it's 19.923 x 19.93 instead of 24 x 24. You can change its size with some applications. 😃
I am so sorry that I cannot help you with this problem. 😭

@DragonStuff DragonStuff marked this pull request as ready for review August 25, 2022 10:06
@DragonStuff
Copy link
Contributor Author

All issues resolved! Ready for review.

CC: @dirien

dirien
dirien approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DragonStuff,

Thanks for your contribution to simple-icons!

It's a perfect fit:
image

@dirien dirien merged commit fe215a5 into simple-icons:develop Aug 25, 2022
@github-actions github-actions bot mentioned this pull request Aug 28, 2022
Merged
mondeja added a commit that referenced this pull request Aug 28, 2022
@mondeja
Release 7 new icons (v7.9.0)
6cdb8ae 
# New Icons

- .ENV (#7702)
- Axios (#5991)
- Ducati (#7678)
- HarmonyOS (#7682)
- Legacy Games (#7704)
- TableCheck (#7696)
- Wacom (#7680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirien dirien dirien approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: TableCheck
3 participants
@DragonStuff @yusancky @dirien