Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StackBlitz icon #7732

Merged
merged 5 commits into from Sep 4, 2022
Merged

Add StackBlitz icon #7732

merged 5 commits into from Sep 4, 2022

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Sep 2, 2022 •
edited

CleanShot 2022-09-02 at 17 12 54@2x

Issue: closes #7681
Similarweb rank: 23,511

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Difference preview

CleanShot 2022-09-02 at 17 19 33@2x

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 2, 2022
@LitoMore LitoMore mentioned this pull request Sep 2, 2022
Closed
dirien
dirien requested changes Sep 3, 2022
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LitoMore,

I see a differences to the original svg.

image

btw: I use the svg from the link in the issue -> https://developer.stackblitz.com/img/open_in_stackblitz.svg

@LitoMore
Copy link
Member Author

LitoMore commented Sep 3, 2022

@dirien I used the icon from the logo on the homepage https://stackblitz.com. I think we should use the one on homepage as standard.

@dirien
Copy link
Member

dirien commented Sep 3, 2022

@LitoMore ok cool! I just checked the description of the issue with the location of the svg!

Will re-review the PR later!

dirien
dirien approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LitoMore ,

It's a perfect fit:
image

@dirien dirien merged commit a748e03 into simple-icons:develop Sep 4, 2022
@LitoMore LitoMore deleted the stackblitz branch September 4, 2022 14:48
This was referenced Sep 6, 2022
Merged
Closed
@janosh
Copy link

janosh commented Sep 8, 2022 •
edited

@LitoMore Thanks! How long do new icons usually take to go live on the website?

@LitoMore
Copy link
Member Author

LitoMore commented Sep 9, 2022

@janosh We will create a release on Sunday: https://github.com/simple-icons/simple-icons/blob/develop/.github/workflows/create-release.yml#L7.

https://github.com/badges/shields.io will create a PR to update the simple-icons to latest on Friday: https://github.com/badges/shields/blob/master/.github/dependabot.yml#L8. But it will take a few days for them to merge.

You could refer to this topic: badges/shields#5369.

@github-actions github-actions bot mentioned this pull request Sep 11, 2022
Merged
mondeja added a commit that referenced this pull request Sep 11, 2022
@mondeja
Release 7 new icons (v7.11.0)
c5eb862 
# New Icons

- Bastyon (#7752)
- Dapr (#7754)
- PocketBase (#7758)
- SecurityScorecard (#7739)
- StackBlitz (#7732)
- Uptime Kuma (#7759)
- XO (#7749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirien dirien dirien approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StackBlitz
3 participants
@LitoMore @dirien @janosh