Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SecurityScorecard icon #7739

Merged
merged 29 commits into from Sep 5, 2022
Merged

Conversation

NoDataFound
Copy link
Contributor

@NoDataFound NoDataFound commented Sep 2, 2022

CleanShot 2022-09-06 at 05 02 38@2x

Issue: closes #7743

Similarweb rank:
Global Rank: 269,180
Country Rank: 105,859
Category Rank: 239

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 2, 2022
@dirien
Copy link
Member

dirien commented Sep 3, 2022

Hi @NoDataFound,

can you create in issue (aka Icon request) and link it to the is PR. Also fill the infos in the PR template.

@NoDataFound
Copy link
Contributor Author

Requested Changes complete.
Issue #7743

Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NoDataFound,

Thanks for your contribution.

I did find some differences with the original SVG linked in the issue:
image

@NoDataFound
Copy link
Contributor Author

Odd and good catch. I am fixing this now, and think the viewbox area was incorrectly scaled.

Copy link
Contributor Author

@NoDataFound NoDataFound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with correct Aspect ratio from source

@NoDataFound
Copy link
Contributor Author

@dirien I updated the svg file and PR with an updated preview.

@LitoMore
Copy link
Member

LitoMore commented Sep 5, 2022

@NoDataFound There is still some difference. Please make sure you enable the aspect ratio lock when you resizing.

CleanShot 2022-09-05 at 14 59 43@2x

@LitoMore LitoMore changed the title Hackbranch Add SecurityScorecard icon Sep 5, 2022
@LitoMore
Copy link
Member

LitoMore commented Sep 5, 2022

CleanShot 2022-09-06 at 04 36 27@2x

@NoDataFound Still not fit. But no worries, let me help you out.

@LitoMore
Copy link
Member

LitoMore commented Sep 5, 2022

CleanShot 2022-09-06 at 05 00 20@2x

Perfect fit now. ✌️

@NoDataFound Thank you for your contributions.

@LitoMore LitoMore merged commit fb813f4 into simple-icons:develop Sep 5, 2022
@NoDataFound
Copy link
Contributor Author

@LitoMore thank you SOOOO much. What was I doing wrong? I really appreciate you correcting the issue and I look forward to adding more.

Any advice or help you could offer would be appreciated.

Thank you again!

@LitoMore
Copy link
Member

LitoMore commented Sep 6, 2022

@NoDataFound I guess it's a clip-path related issue. I ungrouped all groups then removed the clip-path attribute in text mode.

Here are my steps (with Inkscape):

  1. Remove unused shapes
  2. Resize main shape to 24
  3. Align center
  4. Ungroup all groups
  5. Save file
  6. npm run svgo -- icons/securtityscorecard.svg
  7. Open in text mode (any text editor), remove all clip-path related attributes
  8. Remove fills related attributes
  9. Save file
  10. npm run svgo -- icons/securtityscorecard.svg
  11. Done

I'm not a pro at SVG, so I can't tell what you are doing wrong. I only know using those steps may cleans up the clip-path.

@github-actions github-actions bot mentioned this pull request Sep 11, 2022
mondeja added a commit that referenced this pull request Sep 11, 2022
# New Icons

- Bastyon (#7752)
- Dapr (#7754)
- PocketBase (#7758)
- SecurityScorecard (#7739)
- StackBlitz (#7732)
- Uptime Kuma (#7759)
- XO (#7749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SecurityScorecard
3 participants