Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dapr icon #7754

Merged
merged 5 commits into from Sep 8, 2022
Merged

Add Dapr icon #7754

merged 5 commits into from Sep 8, 2022

Conversation

helbing
Copy link
Contributor

@helbing helbing commented Sep 7, 2022

dapr

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 7, 2022
_data/simple-icons.json Outdated Show resolved Hide resolved
@LitoMore
Copy link
Member

LitoMore commented Sep 8, 2022

CleanShot 2022-09-08 at 14 33 36@2x

@helbing I see some differences, could you give a check on this?

@LitoMore
Copy link
Member

LitoMore commented Sep 8, 2022

CleanShot 2022-09-08 at 16 37 18@2x

@helbing Still not fit.

The expected aspect ratio should be:

CleanShot 2022-09-08 at 16 38 02@2x

But yours:

CleanShot 2022-09-08 at 16 38 59@2x

Some SVG editors might snap to pixels by default. Please make sure you didn't enable that kind of feature on your editor.

@helbing
Copy link
Contributor Author

helbing commented Sep 8, 2022

CleanShot 2022-09-08 at 16 37 18@2x

@helbing Still not fit.

The expected aspect ratio should be:

CleanShot 2022-09-08 at 16 38 02@2x

But yours:

CleanShot 2022-09-08 at 16 38 59@2x

Some SVG editors might snap to pixels by default. Please make sure you didn't enable that kind of feature on your editor.

My mistake, It's done now. w: 24, h: 17.636, x: 0, y: 3.182

iShot_2022-09-08_17 34 04

Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2022-09-08 at 22 58 16@2x

@helbing Perfect fit! Thank you for your contributions!

@LitoMore LitoMore changed the title Add dapr icon Add Dapr icon Sep 8, 2022
@LitoMore LitoMore merged commit beb6964 into simple-icons:develop Sep 8, 2022
@helbing helbing deleted the add_dapr_icon branch September 9, 2022 02:23
@github-actions github-actions bot mentioned this pull request Sep 11, 2022
mondeja added a commit that referenced this pull request Sep 11, 2022
# New Icons

- Bastyon (#7752)
- Dapr (#7754)
- PocketBase (#7758)
- SecurityScorecard (#7739)
- StackBlitz (#7732)
- Uptime Kuma (#7759)
- XO (#7749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants