Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tamiya icon #7755

Merged
merged 7 commits into from Sep 21, 2022
Merged

Add Tamiya icon #7755

merged 7 commits into from Sep 21, 2022

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Sep 8, 2022

CleanShot 2022-09-11 at 18 02 08@2x

Similarweb rank: 52,531
Logo resource: https://commons.wikimedia.org/wiki/File:TAMIYA_Logo.svg
Color: #000000
Product reference: https://www.tamiyausa.com/shop/signature-line/tamiya-logo-sticker-white/

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

They don't have any black and white SVG resource on internet. I processed a black and white one based on a colored version.

I also added a gap between the two stars. Because their black and white version always has a gap. BTW, they don't have any standard about the width of the gap. I bought a lot of Tamiya products, the width of each gap is not the same. Here is my Tamiya products list: https://github.com/LitoMore/tamiya-toys.

Difference preview

No needed.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 8, 2022
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LitoMore,

love it!

I found this icon on the German site of Tamiya -> https://www.tamiya.de/build/img/svg/tamiya_logo.svg?v=2.6.0c

Maybe we could use consider this, as it is some kind of official?

@dirien dirien added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Sep 10, 2022
@LitoMore
Copy link
Member Author

@dirien The resource from https://tamiya.de looks not good. The height of those letters is not the same.

CleanShot 2022-09-10 at 20 56 36@2x

Here are some of my Tamiya products:

item-95514 item-94893 item-74039

As you can see, the letters in all those logs are in the same baseline.

So I would prefer to use the resource from Wikimedia.

@LitoMore LitoMore added in discussion There is an ongoing discussion that should be finished before we can continue and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Sep 10, 2022
@LitoMore
Copy link
Member Author

CleanShot 2022-09-08 at 21 24 47@2xBTW, I think we should increase the gap.

Although we have documented that the default gap is 0.5px, I think the gap between the two stars is a major gap. We should increase its width for a better view.

I also discussed this topic with another project owner xojs/xo#689. Their logo is a typical case.

@dirien
Copy link
Member

dirien commented Sep 10, 2022

I like it! @LitoMore! Regarding the gap with: I trust you in this!

@LitoMore
Copy link
Member Author

I decided to remove the text TAMIYA from the logo. I have some logo stickers which bundled in the Mini 4WD products, those stickers only have two stars. And my t-shirt has no text TAMIYA under the logo either.

Currently the gap in shields may look very thin. But I have another approach with shields.io. See badges/shields#8372.

@dirien
Copy link
Member

dirien commented Sep 12, 2022

You let me know, when it's ready to review!

@LitoMore
Copy link
Member Author

@dirien Ready to review now~

@LitoMore LitoMore removed the in discussion There is an ongoing discussion that should be finished before we can continue label Sep 12, 2022
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LitoMore

for me it looks fine, the stars are all shaped the same. As there is no real official svg with the gap etc. I am fine from my side with your suggestion.

image

Maybe get some feedback from @sachinraja too.

@LitoMore
Copy link
Member Author

Merging. Please let me know if you want any further changes.

@LitoMore LitoMore merged commit ddd0290 into simple-icons:develop Sep 21, 2022
@LitoMore LitoMore deleted the tamiya branch September 21, 2022 03:14
LitoMore added a commit to LitoMore/simple-icons that referenced this pull request Sep 21, 2022
mondeja added a commit that referenced this pull request Sep 25, 2022
# New Icons

- Adminer (#7746)
- Amazon Games (#7832)
- CafePress (#7817)
- Electron Fiddle (#7839)
- Fanfou (#7838)
- Fantom (#7030)
- Game Developer (#7806)
- Interaction Design Foundation (#7809)
- JUKE (#7811)
- MacPaw (#7842)
- Relay (#7825)
- ReSharper (#7814)
- Setapp (#7840)
- Shopee (#5896)
- Similarweb (#7841)
- Sonar (#7800)
- Taichi Graphics (#7829)
- Taichi Lang (#7828)
- Tamiya (#7755)
- Tidyverse (#7816)
- Vitest (#7824)
- VSCodium (#7826)
- Warp (#7309)
- ZincSearch (#7837)

# Updated Icons

- ACM (#7855)
- ActiGraph (#7855)
- Activision (#7855)
- AddThis (#7855)
- AdGuard (#7855)
- Aerospike (#7855)
- AEW (#7855)
- Air China (#7855)
- Air France (#7855)
- Alfa Romeo (#7855)
- Alfred (#7855)
- AlloCiné (#7855)
- AllTrails (#7855)
- Apache CloudStack (#7855)
- Apache Cordova (#7855)
- Azure DevOps (#7855)
- Azure Functions (#7855)
- Bootstrap (#7855)
- BorgBackup (#7855)
- Castro (#7855)
- Caterpillar (#7855)
- Co-op (#7855)
- Cockpit (#7855)
- Codeforces (#7855)
- CodeIgniter (#7855)
- CSS Wizardry (#7855)
- CSS3 (#7855)
- Cucumber (#7855)
- DeviantArt (#7855)
- Devpost (#7855)
- Douban (#7843)
- Empire Kred (#7855)
- Enpass (#7855)
- Expo (#7855)
- Express (#7855)
- FeatHub (#7855)
- FedEx (#7855)
- Fiat (#7855)
- Fido Alliance (#7855)
- Fitbit (#7855)
- FITE (#7855)
- Fnac (#7855)
- Folium (#7855)
- Fortinet (#7855)
- Fortran (#7855)
- Git (#7855)
- GoldenLine (#7855)
- Goodreads (#7855)
- Google Sheets (#7855)
- Google Street View (#7855)
- Grav (#7855)
- Gravatar (#7855)
- Hatena Bookmark (#7855)
- haveibeenpwned (#7855)
- HTML5 (#7855)
- HTTPie (#7855)
- Jeep (#7855)
- Jekyll (#7855)
- Komoot (#7855)
- Konami (#7855)
- LINE (#7855)
- LineageOS (#7855)
- LiveJournal (#7855)
- Livewire (#7855)
- Magento (#7855)
- Magisk (#7855)
- MailChimp (#7855)
- Mailgun (#7855)
- MakerBot (#7855)
- MAMP (#7855)
- Matternet (#7855)
- Max (#7855)
- Meteor (#7855)
- Metro (#7855)
- Microgenetics (#7855)
- MicroPython (#7855)
- NetApp (#7855)
- OCaml (#7855)
- Parity Substrate (#7855)
- Parse.ly (#7855)
- Passport (#7855)
- Pastebin (#7855)
- Pepsi (#7855)
- Percy (#7855)
- PHP (#7855)
- Plex (#7799)
- Ram (#7855)
- Rancher (#7855)
- Ruby on Rails (#7855)
- San Francisco Municipal Railway (#7855)
- SanDisk (#7855)
- Sass (#7855)
- Sencha (#7855)
- Sennheiser (#7855)
- Server Fault (#7855)
- SitePoint (#7855)
- Sketch (#7855)
- Skype (#7855)
- Skype for Business (#7855)
- Spacemacs (#7855)
- SSRN (#7855)
- Stack Exchange (#7855)
- Stencyl (#7855)
- Stimulus (#7855)
- StubHub (#7855)
- styled-components (#7855)
- Subversion (#7855)
- suckless (#7855)
- Tinder (#7855)
- TinyLetter (#7855)
- Twoo (#7855)
- Typeform (#7855)
- VLC media player (#7855)
- VMware (#7855)
- WEBTOON (#7855)
- WeChat (#7855)
- Wire (#7855)
- Wix (#7855)
- Wizz Air (#7855)
- Wolfram (#7855)
- Wolfram Language (#7855)
- Wolfram Mathematica (#7855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants