Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Apple News icon #7769

Merged
merged 9 commits into from Sep 13, 2022
Merged

Add Apple News icon #7769

merged 9 commits into from Sep 13, 2022

Conversation

shindgewongxj
Copy link
Contributor

@shindgewongxj shindgewongxj commented Sep 12, 2022 •
edited

Issue: closes #7770

Similarweb rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 12, 2022
@dirien
Copy link
Member

dirien commented Sep 12, 2022

Hi @shindgewongxj,

thanks for the contribution. Can you open an issue, fill out the necessary informations and link to this PR?

@shindgewongxj
Copy link
Contributor Author

Hi @shindgewongxj,

thanks for the contribution. Can you open an issue, fill out the necessary informations and link to this PR?

OFC!

LitoMore
LitoMore requested changes Sep 12, 2022
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
@shindgewongxj
Update simple-icons.json
2a1947f 
Fixed `Apple News` hex code.
@LitoMore
Copy link
Member

CleanShot 2022-09-13 at 15 42 13@2x

I see some differences. Could you give a check?

@shindgewongxj
Copy link
Contributor Author

shindgewongxj commented Sep 13, 2022 •
edited

CleanShot 2022-09-13 at 15 42 13@2x

I see some differences. Could you give a check?

Screenshot 2022-09-13 at 4 56 24 PM

Is that the `Apple News` svg I committed, I reviewed the changes and it showed normally.

@LitoMore
Copy link
Member

@shindgewongxj Please refer to this comment: #7752 (comment).

@shindgewongxj
Copy link
Contributor Author

@shindgewongxj Please refer to this comment: #7752 (comment).

I updated the commit with svgo precision 4.

@LitoMore
Copy link
Member

@shindgewongxj The linting error needs to be fixed.

You could open the SVG file in text mode and then delete the final-new-line.

@shindgewongxj
Copy link
Contributor Author

shindgewongxj commented Sep 13, 2022 •
edited

@shindgewongxj The linting error needs to be fixed.

You could open the SVG file in text mode and then delete the final-new-line.

I'm sorry, I cannot find any extraneous whitespaces or lines.

@LitoMore
Copy link
Member

@shindgewongxj This is the final-new-line.

CleanShot 2022-09-13 at 17 54 22@2x

Fixed for you. Some editors will insert a final-new-line to the file automatically.

I will review the difference later.

@shindgewongxj
Copy link
Contributor Author

shindgewongxj commented Sep 13, 2022 •
edited

@shindgewongxj This is the final-new-line.

CleanShot 2022-09-13 at 17 54 22@2x

Fixed for you. Some editors will insert a final-new-line to the file automatically.

I will review the difference later.

Screenshot 2022-09-13 at 6 09 03 PM

OMG! XXL thanks for your help, it did not even show up when I edited it on GitHub text editor.

@LitoMore
Copy link
Member

CleanShot 2022-09-13 at 18 20 37@2x

@shindgewongxj Perfect fit now!

LitoMore
LitoMore approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shindgewongxj Thank you for your contributions!

@LitoMore LitoMore changed the title Added Apple News. Add Apple News icon Sep 13, 2022
@LitoMore LitoMore merged commit e562ade into simple-icons:develop Sep 13, 2022
@github-actions github-actions bot mentioned this pull request Sep 18, 2022
Merged
mondeja added a commit that referenced this pull request Sep 18, 2022
@mondeja
Release 11 new icons and 7 updated icons (v7.12.0)
50eb494 
# New Icons

- Agora (#7765)
- Algorand (#7772)
- Apple News (#7769)
- Commodore (#7773)
- Dataverse (#7782)
- Google Home (#7771)
- Neutralinojs (#7319)
- Power Fx (#7788)
- Power Pages (#7783)
- Semantic Scholar (#7767)
- Sessionize (#7789)

# Updated Icons

- Andela (#7790)
- Dynamics 365 (#7778)
- Neo4j (#7791)
- Power Apps (#7781)
- Power Automate (#7785)
- Power BI (#7784)
- Power Virtual Agents (#7786)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LitoMore LitoMore LitoMore approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Apple News
3 participants
@shindgewongxj @dirien @LitoMore