Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firewalla icon #7835

Merged
merged 10 commits into from Nov 24, 2022
Merged

Add Firewalla icon #7835

merged 10 commits into from Nov 24, 2022

Conversation

elliotwutingfeng
Copy link
Contributor

@elliotwutingfeng elliotwutingfeng commented Sep 21, 2022

image

Issue: closes #7274

Similarweb rank: 246,296

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

nil

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 21, 2022
@LitoMore
Copy link
Member

@elliotwutingfeng Those paths need to be combined. Use Path -> Uniocn from the menu in Inkscape.

@LitoMore
Copy link
Member

CleanShot 2022-09-22 at 10 47 59@2x

Perfect fit.

@elliotwutingfeng
Copy link
Contributor Author

Do you think gaps are necessary to preserve the details of the flame?

@LitoMore
Copy link
Member

@elliotwutingfeng Good point.

I'd prefer to have gaps.

@simple-icons/icon-review Any thoughts?

Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elliotwutingfeng,

perfect fit!
image

@dirien dirien merged commit 95be8a0 into simple-icons:develop Nov 24, 2022
@elliotwutingfeng elliotwutingfeng deleted the firewalla branch November 24, 2022 15:14
@github-actions github-actions bot mentioned this pull request Nov 27, 2022
mondeja added a commit that referenced this pull request Nov 27, 2022
# New Icons

- Firewalla (#7835)
- Kuula (#8022)
- ReadMe (#8021)
- Red (#8031)
- Wails (#7858)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firewalla
3 participants