Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Douban icon #7843

Merged
merged 1 commit into from Sep 21, 2022
Merged

Update Douban icon #7843

merged 1 commit into from Sep 21, 2022

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Sep 21, 2022

CleanShot 2022-09-21 at 23 42 01@2x

Resource: I picked the from their logo of 豆瓣豆品 product.
Color: #2D963D I picked the color from their logo on https://www.douban.com/about page.

I am a former Douban employee. So I have confidence in the where I picked from. Although Douban (豆瓣) and Douban Market (豆瓣豆品) are different products, their word is the same.

<svg width='135' height='100' xmlns='http://www.w3.org/2000/svg'><path d='M70.301 40.46h24.525V38H70.301v2.46zm5.47 10.528h13.588v-5.362H75.77v5.362zm9.728 8.58h-5.87l-.017-.058-1.765-6.09h9.434l-1.782 6.148zM72.44 53.42h2.282l.017.06 1.764 6.088h-6.744V62H95.37v-2.432h-6.744l1.78-6.148h2.282V43.167H72.44V53.42zm-9.871-11.68l-.263 5.485H61.03l-.004-.078-.263-5.494h1.81l-.003.086zm2.81 11.471h-2.331v-3.605h2.692v-2.38h-1.62l.007-.09.478-5.483h.94v-2.381h-2.497v-2.227h-2.594v2.227H57.74L56.083 37l-7.963 1.967-.003 9.623c0 5.422-.097 8.494-2.177 13.555l1.934.795c2.226-5.418 2.335-8.817 2.335-14.35v-7.883l1.345-.216v19.272l-.076.005-2.15.154.535 2.585 5.342-1.093-.458-1.869-1.307.096V40.227l1.474-.233v8.596c0 2.569 0 8.576 1.827 14.177l1.987-.652c-1.722-5.285-1.722-11.056-1.722-13.525v-8.913l.73-.11v2.086h.994l.006.075.48 5.497h-1.48v2.381h2.718v3.605H58.07v2.382h2.385v7.066h2.594v-7.066h2.331v-2.382zM44.815 41.74l-.263 5.486h-1.277l-.004-.078-.263-5.494h1.811l-.004.086zm.406 12.998l1.746-.38.18-2.143-1.818.267v-2.875h2.327v-2.38h-1.29l.007-.09.478-5.483h.555v-2.382h-2.122v-2.227h-2.479v2.227h-2.344v2.38h.515l.007.076.479 5.497h-1.334v2.381h2.589v3.259l-2.553.375.286 2.534 2.095-.456-.013.115c-.22 1.919-.688 4.551-1.663 6.23L43.112 63c1.42-2.427 1.927-6.177 2.104-8.203l.005-.06zm68.243 7.762H125V49.561h-11.536V62.5zm3.116-2.267h5.31v-8.384h-5.31v8.384zM99.388 62.5h11.576V49.561H99.388V62.5zm3.11-2.267h5.358v-8.384h-5.359v8.384zm1.107-13.033h16.951v-9.7h-16.95v9.701zm3.114-2.267h10.725v-5.14H106.72v5.14zM11.544 40.46h24.524V38H11.544v2.46zm5.468 10.528h13.589v-5.362H17.012v5.362zm9.73 8.58h-5.87l-.018-.058-1.764-6.09h9.433l-1.781 6.148zm-13.06-6.148h2.281l.017.06 1.765 6.088H11V62h25.612v-2.432h-6.744l1.781-6.148h2.28V43.167H13.683V53.42z' fill='#44883E' fill-rule='evenodd'/></svg>

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Difference preview

CleanShot 2022-09-21 at 23 48 44@2x

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Sep 21, 2022
@LitoMore LitoMore merged commit d5444f6 into simple-icons:develop Sep 21, 2022
@LitoMore LitoMore deleted the douban branch September 21, 2022 15:57
@dirien
Copy link
Member

dirien commented Sep 21, 2022

Hi @LitoMore,

are you reviewing your own PRs? Is this now the new workflow?

FYI @simple-icons/maintainers

@LitoMore
Copy link
Member Author

LitoMore commented Sep 21, 2022

Sorry about that, is our PRs always require other reviewers' approval?

If yes, I will wait for others' approval for future PRs.

@LitoMore
Copy link
Member Author

Feel free to revert my merges if you do mind.

@LitoMore
Copy link
Member Author

@dirien Let's chat on Slack.

LitoMore added a commit to LitoMore/simple-icons that referenced this pull request Sep 21, 2022
mondeja added a commit that referenced this pull request Sep 25, 2022
# New Icons

- Adminer (#7746)
- Amazon Games (#7832)
- CafePress (#7817)
- Electron Fiddle (#7839)
- Fanfou (#7838)
- Fantom (#7030)
- Game Developer (#7806)
- Interaction Design Foundation (#7809)
- JUKE (#7811)
- MacPaw (#7842)
- Relay (#7825)
- ReSharper (#7814)
- Setapp (#7840)
- Shopee (#5896)
- Similarweb (#7841)
- Sonar (#7800)
- Taichi Graphics (#7829)
- Taichi Lang (#7828)
- Tamiya (#7755)
- Tidyverse (#7816)
- Vitest (#7824)
- VSCodium (#7826)
- Warp (#7309)
- ZincSearch (#7837)

# Updated Icons

- ACM (#7855)
- ActiGraph (#7855)
- Activision (#7855)
- AddThis (#7855)
- AdGuard (#7855)
- Aerospike (#7855)
- AEW (#7855)
- Air China (#7855)
- Air France (#7855)
- Alfa Romeo (#7855)
- Alfred (#7855)
- AlloCiné (#7855)
- AllTrails (#7855)
- Apache CloudStack (#7855)
- Apache Cordova (#7855)
- Azure DevOps (#7855)
- Azure Functions (#7855)
- Bootstrap (#7855)
- BorgBackup (#7855)
- Castro (#7855)
- Caterpillar (#7855)
- Co-op (#7855)
- Cockpit (#7855)
- Codeforces (#7855)
- CodeIgniter (#7855)
- CSS Wizardry (#7855)
- CSS3 (#7855)
- Cucumber (#7855)
- DeviantArt (#7855)
- Devpost (#7855)
- Douban (#7843)
- Empire Kred (#7855)
- Enpass (#7855)
- Expo (#7855)
- Express (#7855)
- FeatHub (#7855)
- FedEx (#7855)
- Fiat (#7855)
- Fido Alliance (#7855)
- Fitbit (#7855)
- FITE (#7855)
- Fnac (#7855)
- Folium (#7855)
- Fortinet (#7855)
- Fortran (#7855)
- Git (#7855)
- GoldenLine (#7855)
- Goodreads (#7855)
- Google Sheets (#7855)
- Google Street View (#7855)
- Grav (#7855)
- Gravatar (#7855)
- Hatena Bookmark (#7855)
- haveibeenpwned (#7855)
- HTML5 (#7855)
- HTTPie (#7855)
- Jeep (#7855)
- Jekyll (#7855)
- Komoot (#7855)
- Konami (#7855)
- LINE (#7855)
- LineageOS (#7855)
- LiveJournal (#7855)
- Livewire (#7855)
- Magento (#7855)
- Magisk (#7855)
- MailChimp (#7855)
- Mailgun (#7855)
- MakerBot (#7855)
- MAMP (#7855)
- Matternet (#7855)
- Max (#7855)
- Meteor (#7855)
- Metro (#7855)
- Microgenetics (#7855)
- MicroPython (#7855)
- NetApp (#7855)
- OCaml (#7855)
- Parity Substrate (#7855)
- Parse.ly (#7855)
- Passport (#7855)
- Pastebin (#7855)
- Pepsi (#7855)
- Percy (#7855)
- PHP (#7855)
- Plex (#7799)
- Ram (#7855)
- Rancher (#7855)
- Ruby on Rails (#7855)
- San Francisco Municipal Railway (#7855)
- SanDisk (#7855)
- Sass (#7855)
- Sencha (#7855)
- Sennheiser (#7855)
- Server Fault (#7855)
- SitePoint (#7855)
- Sketch (#7855)
- Skype (#7855)
- Skype for Business (#7855)
- Spacemacs (#7855)
- SSRN (#7855)
- Stack Exchange (#7855)
- Stencyl (#7855)
- Stimulus (#7855)
- StubHub (#7855)
- styled-components (#7855)
- Subversion (#7855)
- suckless (#7855)
- Tinder (#7855)
- TinyLetter (#7855)
- Twoo (#7855)
- Typeform (#7855)
- VLC media player (#7855)
- VMware (#7855)
- WEBTOON (#7855)
- WeChat (#7855)
- Wire (#7855)
- Wix (#7855)
- Wizz Air (#7855)
- Wolfram (#7855)
- Wolfram Language (#7855)
- Wolfram Mathematica (#7855)
@ushuz
Copy link

ushuz commented Oct 11, 2022

What do you think about a hollowed that's more similar to Douban's favicon and app logo? Instead of the character?

favicon

app logo

@LitoMore
Copy link
Member Author

I would say no.

For example:

Their brands/trademarks do not contain a background shape.

@ushuz
Copy link

ushuz commented Oct 11, 2022

@LitoMore

Thanks for the response. That's a fair point.

Well, I personally prefer the look of the hollowed version, which IMO augments the glyph in a good way.

I made a hollowed version SVG based on your work. Please allow me to attach it here in case anyone else finds it useful.

<svg viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Douban</title><path fill-rule="evenodd" clip-rule="evenodd" d="M2 0a2 2 0 0 0-2 2v20c0 1.1.9 2 2 2h20a2 2 0 0 0 2-2V2a2 2 0 0 0-2-2H2Zm19.1 4.8H2.9V3h18.2v1.8Zm-1.6 9.6V6.8h-15v7.6h1.7L7.5 19h-5v1.8h19V19h-5l1.3-4.6h1.7Zm-11 0h7L14.2 19H9.8l-1.3-4.6ZM7 8.7h10v4H7v-4Z"/></svg>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants