Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid the usage of non secure URLs #7855

Merged
merged 4 commits into from Sep 24, 2022

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Sep 24, 2022

Changed all URLs to use https:// and tests to forbid http:// protocol in URLs. If a URL is not properly secured with a certificate, a screen like the next will appear in the browser:

image

Closes #7850

@mondeja mondeja added meta Issues or pull requests regarding the project or repository itself icon data labels Sep 24, 2022
@LitoMore
Copy link
Member

Do we need to document this rule in contributing doc?

@mondeja mondeja marked this pull request as draft September 24, 2022 04:16
@mondeja mondeja marked this pull request as ready for review September 24, 2022 05:00
@mondeja mondeja merged commit 3ee620b into simple-icons:develop Sep 24, 2022
@mondeja mondeja deleted the https-sources branch September 24, 2022 15:37
mondeja added a commit that referenced this pull request Sep 25, 2022
# New Icons

- Adminer (#7746)
- Amazon Games (#7832)
- CafePress (#7817)
- Electron Fiddle (#7839)
- Fanfou (#7838)
- Fantom (#7030)
- Game Developer (#7806)
- Interaction Design Foundation (#7809)
- JUKE (#7811)
- MacPaw (#7842)
- Relay (#7825)
- ReSharper (#7814)
- Setapp (#7840)
- Shopee (#5896)
- Similarweb (#7841)
- Sonar (#7800)
- Taichi Graphics (#7829)
- Taichi Lang (#7828)
- Tamiya (#7755)
- Tidyverse (#7816)
- Vitest (#7824)
- VSCodium (#7826)
- Warp (#7309)
- ZincSearch (#7837)

# Updated Icons

- ACM (#7855)
- ActiGraph (#7855)
- Activision (#7855)
- AddThis (#7855)
- AdGuard (#7855)
- Aerospike (#7855)
- AEW (#7855)
- Air China (#7855)
- Air France (#7855)
- Alfa Romeo (#7855)
- Alfred (#7855)
- AlloCiné (#7855)
- AllTrails (#7855)
- Apache CloudStack (#7855)
- Apache Cordova (#7855)
- Azure DevOps (#7855)
- Azure Functions (#7855)
- Bootstrap (#7855)
- BorgBackup (#7855)
- Castro (#7855)
- Caterpillar (#7855)
- Co-op (#7855)
- Cockpit (#7855)
- Codeforces (#7855)
- CodeIgniter (#7855)
- CSS Wizardry (#7855)
- CSS3 (#7855)
- Cucumber (#7855)
- DeviantArt (#7855)
- Devpost (#7855)
- Douban (#7843)
- Empire Kred (#7855)
- Enpass (#7855)
- Expo (#7855)
- Express (#7855)
- FeatHub (#7855)
- FedEx (#7855)
- Fiat (#7855)
- Fido Alliance (#7855)
- Fitbit (#7855)
- FITE (#7855)
- Fnac (#7855)
- Folium (#7855)
- Fortinet (#7855)
- Fortran (#7855)
- Git (#7855)
- GoldenLine (#7855)
- Goodreads (#7855)
- Google Sheets (#7855)
- Google Street View (#7855)
- Grav (#7855)
- Gravatar (#7855)
- Hatena Bookmark (#7855)
- haveibeenpwned (#7855)
- HTML5 (#7855)
- HTTPie (#7855)
- Jeep (#7855)
- Jekyll (#7855)
- Komoot (#7855)
- Konami (#7855)
- LINE (#7855)
- LineageOS (#7855)
- LiveJournal (#7855)
- Livewire (#7855)
- Magento (#7855)
- Magisk (#7855)
- MailChimp (#7855)
- Mailgun (#7855)
- MakerBot (#7855)
- MAMP (#7855)
- Matternet (#7855)
- Max (#7855)
- Meteor (#7855)
- Metro (#7855)
- Microgenetics (#7855)
- MicroPython (#7855)
- NetApp (#7855)
- OCaml (#7855)
- Parity Substrate (#7855)
- Parse.ly (#7855)
- Passport (#7855)
- Pastebin (#7855)
- Pepsi (#7855)
- Percy (#7855)
- PHP (#7855)
- Plex (#7799)
- Ram (#7855)
- Rancher (#7855)
- Ruby on Rails (#7855)
- San Francisco Municipal Railway (#7855)
- SanDisk (#7855)
- Sass (#7855)
- Sencha (#7855)
- Sennheiser (#7855)
- Server Fault (#7855)
- SitePoint (#7855)
- Sketch (#7855)
- Skype (#7855)
- Skype for Business (#7855)
- Spacemacs (#7855)
- SSRN (#7855)
- Stack Exchange (#7855)
- Stencyl (#7855)
- Stimulus (#7855)
- StubHub (#7855)
- styled-components (#7855)
- Subversion (#7855)
- suckless (#7855)
- Tinder (#7855)
- TinyLetter (#7855)
- Twoo (#7855)
- Typeform (#7855)
- VLC media player (#7855)
- VMware (#7855)
- WEBTOON (#7855)
- WeChat (#7855)
- Wire (#7855)
- Wix (#7855)
- Wizz Air (#7855)
- Wolfram (#7855)
- Wolfram Language (#7855)
- Wolfram Mathematica (#7855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we allow non-secure http:// sources?
2 participants