Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fireship icon #7864

Merged
merged 3 commits into from Oct 5, 2022
Merged

Add Fireship icon #7864

merged 3 commits into from Oct 5, 2022

Conversation

pAkalpa
Copy link
Contributor

@pAkalpa pAkalpa commented Sep 25, 2022

Issue: closes #7845

Similarweb rank:134,815

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

nil

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 25, 2022
sisp
sisp reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @pAkalpa! 🙏

There is only a minor difference between the original icon and yours at the curved path segment on the left side, but I think that's because of the reduced precision. I think it's sufficiently minor to leave it like this. 👍

I have a minor inline comment related to the brand color though.

_data/simple-icons.json Outdated Show resolved Hide resolved
pAkalpa and others added 2 commits October 5, 2022 12:53
@pAkalpa @sisp
Update _data/simple-icons.json
3029a36 
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
@sisp
Merge branch 'develop' into fireship
c196244
sisp
sisp approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! 🎉 Thanks again, @pAkalpa! 🙏

@sisp sisp merged commit 532fb1d into simple-icons:develop Oct 5, 2022
@github-actions github-actions bot mentioned this pull request Oct 9, 2022
Merged
mondeja added a commit that referenced this pull request Oct 9, 2022
@mondeja
Release 10 new icons (v7.15.0)
1d6b2b3 
# New Icons

- Backblaze (#7923)
- Billboard (#7892)
- Crayon (#7908)
- Fireship (#7864)
- Hedera (#7913)
- Instructure (#7891)
- Penpot (#7911)
- Persistent (#7912)
- PySyft (#7914)
- RSocket (#7907)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisp sisp sisp approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fireship.io
2 participants
@pAkalpa @sisp