Add Billboard icon #7892
Merged
Add Billboard icon #7892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
new icon
|
May I please know, how much time it takes for the PRs to merge once all the checks have passed? |
|
@Anmol-Baranwal There is no exact time. We maintain this project when we are free. After all the checks have passed, we need to review your icon to ensure the processed shape perfectly fits the original shape. For example this: #7752. |
LitoMore
requested changes
Oct 1, 2022
There was a problem hiding this comment.
@Anmol-Baranwal I see some differences. Could you re-process with precision 4? Use the command below:
npm run svgo -- -p 4 icons/billboard.svg
|
Is this precision satisfactory? |
|
@Anmol-Baranwal I still see some differences. Let's use this below (with precision 5): <svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Billboard</title><path d="M3.69685 11.02465h1.12413v3.41864H3.69685Zm1.35662-1.33669h1.12381v4.75533H5.05347Zm1.35641 0H7.5337v4.75533H6.40988Zm13.22037 1.68925v-.35256h-1.12397v3.41864h1.12397v-1.6293c0-.41916.21904-.64528.61843-.64528h.133v-1.17728c-.33918.01334-.58533.11975-.75143.38579zM4.2588 9.50287c-.35974 0-.65171.29187-.65171.65182 0 .35994.29197.65192.6517.65192.36006 0 .65182-.29198.65182-.65192 0-.35995-.29176-.65182-.65181-.65182zm12.89058 1.78207c-.15798-.17233-.52558-.31455-.80468-.31455-.84888 0-1.45782.55964-1.6069 1.39153-.1625-.79809-.8581-1.41215-1.70633-1.41215-.85636 0-1.55753.62123-1.71082 1.4343-.1488-.84507-.81354-1.40519-1.6379-1.40519-.30589 0-.55874.06655-.7783.21936v-1.5097H7.78063v4.75528h1.10409v-.3127c.26603.24615.55194.3592.90456.3592.75922 0 1.39843-.59433 1.53517-1.41357.1611.80168.85261 1.4111 1.70707 1.4111.84713 0 1.52653-.5965 1.69943-1.37761.14296.8532.81898 1.38689 1.62698 1.38689.2791 0 .58527-.0934.79145-.24615v.19284h1.12381v-1.49616a8.92817 8.92817 0 0 0-.0016-.1796 8.7632 8.7632 0 0 0 .0016-.17955v-1.55806H17.1494zm-7.58627 2.11732c-.35995 0-.6517-.29187-.6517-.65192 0-.35984.29175-.65165.6517-.65165.35984 0 .6517.29181.6517.65165.00006.36005-.2918.65192-.6517.65192zm3.46836-.0522c-.35973 0-.65181-.29208-.65181-.65192 0-.35978.29208-.65165.65181-.65165.35984 0 .6517.29187.6517.65165.00006.35979-.2917.65192-.6517.65192zm3.3773.02067c-.35995 0-.65145-.29208-.65145-.65192 0-.35978.29145-.65165.65145-.65165.36026 0 .6517.29187.6517.65165.00006.35984-.29144.65192-.6517.65192zm6.46693-3.6833v1.50976c-.21915-.15292-.4719-.21936-.77816-.21936-.93767 0-1.66916.72485-1.66916 1.76914 0 .98418.70492 1.7424 1.56307 1.7424.35224 0 .6382-.11315.90445-.35915v.3126H24V9.68743Zm-.66194 3.7064c-.35947 0-.65144-.29208-.65144-.65166 0-.36005.29187-.65202.65144-.65202.36005 0 .65192.29197.65192.65202 0 .35958-.29187.65166-.65192.65166zm-20.31164-2.415c-.306 0-.55864.06655-.77832.21936V9.68854H0v4.75528h1.10399v-.3127c.26603.24615.55204.3592.90466.3592.85783 0 1.5628-.75843 1.5628-1.74261 0-1.04393-.7316-1.76888-1.66932-1.76888zm-.11965 2.42343c-.35984 0-.6517-.29187-.6517-.65192 0-.35984.29186-.65165.6517-.65165.35995 0 .65171.29181.65171.65165 0 .36005-.29176.65192-.6517.65192z"/></svg>I have already reviewed the difference:
|
|
Do I have to use precision 5 on this processed one: or use precision 5 on the svg from scratch ? Uptill now, I have been doing it from scratch, and both of the above gives a slight different result. |
LitoMore
reviewed
Oct 4, 2022
LitoMore
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #7885
Similarweb rank:
Global rank: 4,506
https://www.similarweb.com/website/billboard.com/#overviewChecklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
SVG logo is retrieved from: https://www.billboard.com/
The hex value is extracted from the official website & company logo from Facebook.