New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crayon icon #7908
Add Crayon icon #7908
Conversation
Interesting that both Inkscape and Affinity Designer say in the UI the file is 24 wide but this failed result says the width is 23.999. I am trying to contribute when I can so I can keep practicing these skills. Does anyone have any advise? The only thing I can think of is adding .001 to the width which appears not to affect the height when scaled proportionately. |
Hi @ericsalvi, thank you for working on it! There are two solutions: Solution 1: Increase the precisionYou need to re-process the icon with higher precision: npm run svgo -- -p 4 icons/crayon.svg Solution 2: Re-center your processed iconUse Inkscape or other SVG editors to reopen your processed file, re-resize it to 24px, and re-center it. |
I tried doing all the suggestions @LitoMore but for some odd reason either Affinity Designer, Inkscape, or Illustrator cannot get the size to be exact. I did run the CLI in solution 1 but no luck. I may not be able to fix this so this pull request may want to be deleted unless others may want to give it a try. |
@ericsalvi It's OK. Let me help you out. |
@ericsalvi I processed with precision 4. |
Thank you @LitoMore this one was a learning experience for me. Out of curiosity did you see any issues on your end or was it a piece of cake to fix? |
I just processed the original icon with precision 4. Here are my steps to add a new icon:
|
Similarweb rank: 109,768
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
They help clients select the best solutions for their business needs and budget to thrive and innovate with software, cloud, data, and AI.