Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crayon icon #7908

Merged
merged 8 commits into from Oct 4, 2022
Merged

Add Crayon icon #7908

merged 8 commits into from Oct 4, 2022

Conversation

ericsalvi
Copy link
Contributor

@ericsalvi ericsalvi commented Oct 2, 2022

CleanShot 2022-10-04 at 13 09 00@2x

Similarweb rank: 109,768

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

They help clients select the best solutions for their business needs and budget to thrive and innovate with software, cloud, data, and AI.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Oct 2, 2022
@ericsalvi
Copy link
Contributor Author

ericsalvi commented Oct 2, 2022

Interesting that both Inkscape and Affinity Designer say in the UI the file is 24 wide but this failed result says the width is 23.999. I am trying to contribute when I can so I can keep practicing these skills. Does anyone have any advise?

The only thing I can think of is adding .001 to the width which appears not to affect the height when scaled proportionately.

@LitoMore
Copy link
Member

LitoMore commented Oct 3, 2022

Hi @ericsalvi, thank you for working on it! There are two solutions:

Solution 1: Increase the precision

You need to re-process the icon with higher precision:

npm run svgo -- -p 4 icons/crayon.svg

Solution 2: Re-center your processed icon

Use Inkscape or other SVG editors to reopen your processed file, re-resize it to 24px, and re-center it.

@ericsalvi
Copy link
Contributor Author

I tried doing all the suggestions @LitoMore but for some odd reason either Affinity Designer, Inkscape, or Illustrator cannot get the size to be exact. I did run the CLI in solution 1 but no luck. I may not be able to fix this so this pull request may want to be deleted unless others may want to give it a try.

@LitoMore
Copy link
Member

LitoMore commented Oct 3, 2022

@ericsalvi It's OK. Let me help you out.

@LitoMore
Copy link
Member

LitoMore commented Oct 4, 2022

CleanShot 2022-10-04 at 12 58 02@2x

@ericsalvi I processed with precision 4.

@LitoMore LitoMore changed the title Adding Crayon icon Add Crayon icon Oct 4, 2022
@LitoMore LitoMore merged commit 1eda765 into simple-icons:develop Oct 4, 2022
@ericsalvi
Copy link
Contributor Author

Thank you @LitoMore this one was a learning experience for me. Out of curiosity did you see any issues on your end or was it a piece of cake to fix?

@LitoMore
Copy link
Member

LitoMore commented Oct 4, 2022

I just processed the original icon with precision 4.

Here are my steps to add a new icon:

  1. Download the original icon from their homepage
  2. Open the icon in Inkscape
  3. Change viewbox to 24x24
  4. Delete unused shapes
  5. Group the remaining two shapes
  6. Resize this group to 24px with aspect ratio lock
  7. Vertical and horizontal center it
  8. Save it to a new file and move it to icons/crayon.svg
  9. Use npm run add-icon-data to add metadata to _data/simple-icons.json
  10. Run npm run svgo -- -p 4 icons/crayon.svg
  11. Open icons/crayon.svg with a text editor, cleanup unused attributes, and add <title>Crayon</title>
  12. Run npm run lint to test it on local, it should pass
  13. Done

@ericsalvi ericsalvi deleted the adding-crayon branch October 6, 2022 21:46
@github-actions github-actions bot mentioned this pull request Oct 9, 2022
mondeja added a commit that referenced this pull request Oct 9, 2022
# New Icons

- Backblaze (#7923)
- Billboard (#7892)
- Crayon (#7908)
- Fireship (#7864)
- Hedera (#7913)
- Instructure (#7891)
- Penpot (#7911)
- Persistent (#7912)
- PySyft (#7914)
- RSocket (#7907)
@LitoMore LitoMore mentioned this pull request Oct 10, 2022
3 tasks
@marcopollivier marcopollivier mentioned this pull request Oct 15, 2022
3 tasks
@LitoMore LitoMore mentioned this pull request Oct 17, 2022
3 tasks
@LitoMore LitoMore mentioned this pull request Nov 1, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants