Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Penpot icon #7911

Merged
merged 5 commits into from Oct 6, 2022
Merged

Add Penpot icon #7911

merged 5 commits into from Oct 6, 2022

Conversation

adsingh14
Copy link
Contributor

@adsingh14 adsingh14 commented Oct 3, 2022

penpot

Issue: closes #6664

Similarweb rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Extracted from website header and edited in Inkscape, then rendered from SVGO with precision: 3

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Oct 3, 2022
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @adsingh14! 🙏

Any reason why you're using a precision of 4 instead of the default 3? I've also left an inline comment regarding the source URL.

_data/simple-icons.json Outdated Show resolved Hide resolved
@adsingh14
Copy link
Contributor Author

Thanks for your contribution, @adsingh14! 🙏

Any reason why you're using a precision of 4 instead of the default 3? I've also left an inline comment regarding the source URL.

Is there any difference between the original and this icon? If so, then I'll proceed with another icon.

@sisp
Copy link
Contributor

sisp commented Oct 5, 2022

I haven't checked yet because the default precision is 3 and I was wondering whether you had noticed a need to increase it to 4. If we can get an accurate icon with a precision of 3, that would be better.

@adsingh14
Copy link
Contributor Author

I hope the current icon is perfectly fit for this icon.

image

@adsingh14 adsingh14 requested a review from sisp October 5, 2022 11:11
@sisp
Copy link
Contributor

sisp commented Oct 5, 2022

The icon might be a perfect fit, I was just wondering whether a precision of 3 would suffice without sacrificing accuracy. I.e.: If you optimized the icon to a precision of 3, would the fit be good, too?

_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
icons/penpot.svg Outdated Show resolved Hide resolved
@LitoMore LitoMore changed the title penpot icon Add Penpot icon Oct 6, 2022
@adsingh14
Copy link
Contributor Author

@adsingh14 Looks good. Thanks!

It looks almost the same with precision 4 too.

Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2022-10-06 at 18 35 41@2x

@adsingh14 Yes. Precison 3 looks good as well.

@LitoMore LitoMore merged commit 0b41599 into simple-icons:develop Oct 6, 2022
@adsingh14 adsingh14 deleted the penpot branch October 6, 2022 11:04
@github-actions github-actions bot mentioned this pull request Oct 9, 2022
mondeja added a commit that referenced this pull request Oct 9, 2022
# New Icons

- Backblaze (#7923)
- Billboard (#7892)
- Crayon (#7908)
- Fireship (#7864)
- Hedera (#7913)
- Instructure (#7891)
- Penpot (#7911)
- Persistent (#7912)
- PySyft (#7914)
- RSocket (#7907)
@adamrusted adamrusted mentioned this pull request Jul 4, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Penpot
3 participants