Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Persistent icon #7912

Merged
merged 8 commits into from Oct 5, 2022
Merged

Add Persistent icon #7912

merged 8 commits into from Oct 5, 2022

Conversation

adsingh14
Copy link
Contributor

Persistent

Issue: closes #6059

Similarweb rank: 495,248

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Oct 3, 2022
sisp
sisp suggested changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @adsingh14! 🙏

I see some notable differences between the original icon and yours:

Could you please give it another try? 🙏

I also have a minor request for change regarding the source URL. Please see my inline comment.

_data/simple-icons.json Outdated Show resolved Hide resolved
@sisp sisp changed the title Persistent icon Add Persistent icon Oct 5, 2022
@adsingh14 adsingh14 requested a review from sisp October 5, 2022 11:05
sisp
sisp reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon looks good now. 🎉

Just the one request regarding the source URL is still open.

@adsingh14 @sisp
Update _data/simple-icons.json
cd2c049 
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
@adsingh14 adsingh14 requested a review from sisp October 5, 2022 16:12
sisp
sisp approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! 🎉 Thanks again, @adsingh14! 🙏

@sisp
Copy link
Contributor

sisp commented Oct 5, 2022

Hm, not sure why the checks aren't running. 🤔 Any idea, @simple-icons/maintainers?

@LitoMore
Copy link
Member

LitoMore commented Oct 5, 2022

I triggered the CI manually. Now looks good.

@LitoMore LitoMore merged commit bcca774 into simple-icons:develop Oct 5, 2022
@adsingh14 adsingh14 deleted the persistent branch October 5, 2022 17:42
@github-actions github-actions bot mentioned this pull request Oct 9, 2022
Merged
mondeja added a commit that referenced this pull request Oct 9, 2022
@mondeja
Release 10 new icons (v7.15.0)
1d6b2b3 
# New Icons

- Backblaze (#7923)
- Billboard (#7892)
- Crayon (#7908)
- Fireship (#7864)
- Hedera (#7913)
- Instructure (#7891)
- Penpot (#7911)
- Persistent (#7912)
- PySyft (#7914)
- RSocket (#7907)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisp sisp sisp approved these changes

@LitoMore LitoMore LitoMore approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Persistent Company Logo
3 participants
@adsingh14 @sisp @LitoMore