New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hedera icon #7913
Add Hedera icon #7913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @adsingh14! 🙏
I see some notable differences between the original icon (black-cutout.svg
in the "STANDARD" .zip file) and yours:
Could you please give it another try? It might help to perform the conversion with the highest possible precision your SVG editor supports and let SVGO/SVGOMG perform the precision reduction afterwards.
@sisp Can you please check the attached image? |
I don't know how you created the diffs, but mine shows some non-negligible differences. I used Boxy SVG, imported the original icon, converted it with maximum precision, imported yours, and computed the diff using the |
CleanShot.2022-10-06.at.00.45.53.mp4I think the small difference can be accepted. I tried to scale it a lot. But the difference is still very thin. |
@LitoMore I think the difference is more visible at the edge of the circle. 🤔 Curves and arcs are sometimes difficult to convert accurately with reduced precision. I'm not opposed to accepting the current icon if you think it's sufficiently accurate. |
CleanShot.2022-10-06.at.01.10.47.mp4@sisp Ah, you are right. Let me try to process one and see what happened. |
I'm pushing the same icon, again, after checking via Boxy SVG |
@sisp I tried with precision 5 but still have problems. I think we can consider it good enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LitoMore @adsingh14 Alright then, let's keep it as it is now.
Issue: closes #6112
Similarweb rank: 179,123
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description