Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hedera icon #7913

Merged
merged 5 commits into from Oct 5, 2022
Merged

Add Hedera icon #7913

merged 5 commits into from Oct 5, 2022

Conversation

adsingh14
Copy link
Contributor

hedera

Issue: closes #6112

Similarweb rank: 179,123

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Oct 3, 2022
@sisp sisp changed the title Hedera-icon Add Hedera icon Oct 5, 2022
Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @adsingh14! 🙏

I see some notable differences between the original icon (black-cutout.svg in the "STANDARD" .zip file) and yours:

Could you please give it another try? It might help to perform the conversion with the highest possible precision your SVG editor supports and let SVGO/SVGOMG perform the precision reduction afterwards.

@adsingh14
Copy link
Contributor Author

@sisp Can you please check the attached image?
On the right side, I overlapped my version over the original icon and on the other side, I overlapped the original-on-original icon.
test-1

@adsingh14 adsingh14 requested a review from sisp October 5, 2022 08:51
@sisp
Copy link
Contributor

sisp commented Oct 5, 2022

I don't know how you created the diffs, but mine shows some non-negligible differences. I used Boxy SVG, imported the original icon, converted it with maximum precision, imported yours, and computed the diff using the Exclude operation.

@LitoMore
Copy link
Member

LitoMore commented Oct 5, 2022

CleanShot.2022-10-06.at.00.45.53.mp4

I think the small difference can be accepted. I tried to scale it a lot. But the difference is still very thin.

@sisp
Copy link
Contributor

sisp commented Oct 5, 2022

@LitoMore I think the difference is more visible at the edge of the circle. 🤔 Curves and arcs are sometimes difficult to convert accurately with reduced precision. I'm not opposed to accepting the current icon if you think it's sufficiently accurate.

@LitoMore
Copy link
Member

LitoMore commented Oct 5, 2022

CleanShot.2022-10-06.at.01.10.47.mp4

@sisp Ah, you are right. Let me try to process one and see what happened.

@adsingh14
Copy link
Contributor Author

I don't know how you created the diffs, but mine shows some non-negligible differences.

I'm pushing the same icon, again, after checking via Boxy SVG

@LitoMore
Copy link
Member

LitoMore commented Oct 5, 2022

@sisp I tried with precision 5 but still have problems. I think we can consider it good enough.

Copy link
Contributor

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LitoMore @adsingh14 Alright then, let's keep it as it is now.

@sisp sisp merged commit 617d268 into simple-icons:develop Oct 5, 2022
@adsingh14 adsingh14 deleted the hedera branch October 5, 2022 17:53
@adsingh14 adsingh14 restored the hedera branch October 5, 2022 17:53
@github-actions github-actions bot mentioned this pull request Oct 9, 2022
mondeja added a commit that referenced this pull request Oct 9, 2022
# New Icons

- Backblaze (#7923)
- Billboard (#7892)
- Crayon (#7908)
- Fireship (#7864)
- Hedera (#7913)
- Instructure (#7891)
- Penpot (#7911)
- Persistent (#7912)
- PySyft (#7914)
- RSocket (#7907)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hedera Hashgraph Icon
3 participants