Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Backstage logo #7949

Merged
merged 15 commits into from Oct 16, 2022
Merged

Add Backstage logo #7949

merged 15 commits into from Oct 16, 2022

Conversation

marcopollivier
Copy link
Contributor

@marcopollivier marcopollivier commented Oct 12, 2022

Issue: closes #7948

Similarweb rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

This PR adds the Backstage logo

I based this PR with the original documentation https://backstage.io/docs/overview/logos

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Oct 12, 2022
@marcopollivier marcopollivier marked this pull request as ready for review October 15, 2022 02:31
@marcopollivier
Copy link
Contributor Author

@LitoMore this thread helped me a lot. #7908 (comment)

Is it makes sense to be part of the documentation?

@LitoMore
Copy link
Member

@marcopollivier The problems you'll run into when processing with icons can vary, and the ones I've mentioned in the comments are just the smoothest. In practice, there may be more problems, and if you want to write a document, it will be complicated and difficult to read.

We already have several related discussions, and I prefer to share the basic principles of SVG and how to use the editor, rather than writing a step-by-step tutorial:

@marcopollivier
Copy link
Contributor Author

Hmmm. Makes sense. 🤔

@LitoMore LitoMore changed the title Add backstage logo Add Backstage logo Oct 15, 2022
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2022-10-15 at 20 48 44@2x

@marcopollivier There are some differences.

According to their guidelines, we'd better use the teal one as a reference.

These links can be found at https://backstage.io/docs/overview/logos.

@marcopollivier
Copy link
Contributor Author

@LitoMore I changed, but I'd like to validate as you did 🤔

Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marcopollivier ,

Thanks for your contribution to simple-icons!

It's a perfect fit:
image

@dirien dirien merged commit 220e6b6 into simple-icons:develop Oct 16, 2022
@LitoMore
Copy link
Member

@marcopollivier For reviewing the difference, see #7752 (comment).

mondeja added a commit that referenced this pull request Oct 23, 2022
# New Icons

- Backstage (#7949, #7965)
- E3 (#7876)
- Elgato (#7884)
- Iced (#7961, #7966)
- StandardJS (#7929)

# Updated Icons

- Linktree (#7962)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Backstage icon
3 participants