Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADP icon #8014

Merged
merged 3 commits into from Nov 14, 2022
Merged

Add ADP icon #8014

merged 3 commits into from Nov 14, 2022

Conversation

Jwaegebaert
Copy link
Contributor

@Jwaegebaert Jwaegebaert commented Nov 3, 2022

Issue: No related issue

Similarweb rank: 570

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The icon was found using element inspect on the ADL homepage. Here I found a direct link to the SVG.
The HEX value #D0271D was fetched from the SVG icon.

adp

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Nov 3, 2022
@LitoMore
Copy link
Member

LitoMore commented Nov 4, 2022

CleanShot 2022-11-04 at 21 08 42@2x

@Jwaegebaert I see some differences. Could you check this?

@Jwaegebaert
Copy link
Contributor Author

Hey @LitoMore, how can I tackle this? Currently, I use svgomg to simplify the SVG file. Would increasing the precision here help?

@LitoMore
Copy link
Member

@Jwaegebaert Yes. Increasing the precision might help. And make sure you enabled the aspect ratio lock when resizing the icon.

@Jwaegebaert
Copy link
Contributor Author

I rescaled the image from the starting SVG to make sure it isn't warped and added more precision with ´svgomg´

Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2022-11-14 at 21 15 49@2x

@Jwaegebaert Perfect fit now. Thank you!

@LitoMore LitoMore changed the title Added ADP logo Add ADP icon Nov 14, 2022
@LitoMore LitoMore merged commit 5434e11 into simple-icons:develop Nov 14, 2022
MaximGns pushed a commit to MaximGns/simple-icons that referenced this pull request Nov 16, 2022
Co-authored-by: LitoMore <LitoMore@users.noreply.github.com>

Hyva themes

Update size and json

Update naming

Update svg

Test
@github-actions github-actions bot mentioned this pull request Nov 20, 2022
mondeja added a commit that referenced this pull request Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants